[BUG] Generated geometry is incorrect and cannot be properly extruded using the solidify modifier

wipmate commented 7 months ago

Description

When creating a geometry using 2D arcs in a specific arrangement, the resulting bezier/mesh has some artifacts which make it difficult to continue working with the generated mesh.

Steps to reproduce:

Create new blender project
Sketch shapes using 2D arcs and lines (must have some complexity, e.g. as shown in the attached video)
Convert the sketch to a mesh
Apply the "Solidify" modifier and increase thickness to observe the artifacts

https://github.com/hlorus/CAD_Sketcher/assets/10092394/71886418-26cd-4328-9a53-75fad389443b

Download the model as shown in the video: broken_sketch_solidify.zip

(Apparently I don't get any logs from the plugin.)

PS: Huge shoutout to this project, it has already served me well in the past and I hope to continue my work with it!

Addon Version

0.27.3

Blender Version

4.0

Platform

Windows

dtremain commented 3 months ago

This is similar to my issue #440. I have reproduced this bug using points and lines, and changing the Mesh Curve Resolution to 1 did not "fix" it. The .zip contains the .blend file and a .txt file that describes the steps I used to create it. Bug440.zip bs_Shaft2Err

I can create a cross shaft using two sketches - one a horizontal rectangle, the other a vertical rectangle, and then boolean UNION them together. You MUST use the Point / Line approach if you encase the plus object (shaft) in a circle to get a bore because the two union'ed rectangles do not work.

jmsunseri commented 2 months ago

i'm experience a similar issue (see sketch) with a bunch of holes in a flat plane . i tired the "trick" to see if different mesh curve resolutions would solve the issue but so far i'm unable to find one. the best i can tell it's an issue with face orientation so that the solidify is happening in the opposite direction indicated by the offset

This is a serious blocker. Anything aside from the simplest topology results in issues.

I seem to be able to manually work around the issue for now by extruding manually

Miguel-Rodrigues commented 1 month ago

A workaround that I documented on the Discord before is to remesh the object using the mesh to curve and fill curve nodes on geometry nodes, before Solidify,

I suspect that this happens due to the order of how the model was sketched and constrained, causing the creation of excess points with wrong rotations, when filling the shape. So don't use the built-in "Fill Shape option" or use object type "Curve", if this happens.

https://discord.com/channels/882152824249667594/1067824923516616805/1073001503519944826 https://discord.com/channels/882152824249667594/966814731472093184/1072660538313674772

KoDeltaS commented 1 month ago

Hi @wipmate , @dtremain , @jmsunseri , @hlorus , I tried to reproduce your issues and found a solution that works and the reason causing the problem.

The problem comes from the fact that Fill Shape doesn’t work well with complex shapes. Don't know if adding/switching to bpy.ops.mesh.beauty_fill() in mesh converter could work better.

Solution: -Update the sketches by unchecking Fill Shape. -Exit the sketch. -Duplicate your mesh (if you go back to sketch mode, the changes will be lost). -Select the copied mesh, in Edit Mode (select everything with A) use ALT + F to fill. If you have complex geometry and ALT + F doesn’t work, create face "islands" manually.

I think it would be advisable to recommend using a step-by-step workflow:

-Sketch for basic geometries -Sketch of shapes to use as booleans

F_Bug Cross_Islands Cross_Z

dtremain commented 1 month ago

I'm really confused. It sounds like the software is using data points that are not created by the user and that are not visible to the user. In its simplest form, this occurs when drawing a plus - all straight lines and right angles. I have seen it exhibit this behavior when drawing two rectangles (one for vertical arms, and one for horizontal), and when placing the vertices and drawing lines around the figure in sequence. And I've also seen the software work as expected using both of those methods.

I have not tried to turn off the fill (which, from a user perspective, makes no sense - turn off the Fill option to get fill).

Part of correct functionality of software (and perceived quality) has to do with usability - not just whether the software will perform the desired task if coaxed correctly.

Can someone explain to me why the software can't use just the user-defined defined vertices, arcs, lines, and circles to create the fill? Yes, the order in which they are defined might make a difference, but that should be a rather unusual case, one would think.

David Tremain

From: KoDeltaS @.> Sent: Tuesday, September 3, 2024 3:29 PM To: hlorus/CAD_Sketcher @.> Cc: dtremain @.>; Mention @.> Subject: Re: [hlorus/CAD_Sketcher] [BUG] Generated geometry is incorrect and cannot be properly extruded using the solidify modifier (Issue #447)

Hi @wipmatehttps://github.com/wipmate , @dtremainhttps://github.com/dtremain , @jmsunserihttps://github.com/jmsunseri , @hlorushttps://github.com/hlorus , I tried to reproduce your issues and found a solution that works and the reason causing the problem.

The problem comes from the fact that Fill Shape doesn’t work well (it’s probably like a simple F in Edit Mode).

Solution: -Update the sketches by unchecking Fill Shape. -Exit the sketch. -Duplicate your mesh (if you go back to sketch mode, the changes will be lost). -Select the copied mesh, in Edit Mode (select everything with A) use ALT + F to fill. If you have complex geometry and ALT + F doesn’t work, create face "islands" manually.

I think it would be advisable to recommend using a step-by-step workflow:

-Sketch for basic geometries -Sketch of shapes to use as booleans

F_Bug.png (view on web)https://github.com/user-attachments/assets/6f91dc2e-942a-48d7-912f-0d485e7e30b6 Cross_Islands.png (view on web)https://github.com/user-attachments/assets/9898820e-a4ce-4def-bd86-93abfb5a41bc Cross_Z.png (view on web)https://github.com/user-attachments/assets/bb303ba6-cf29-41b9-849f-370e0d65cfda

— Reply to this email directly, view it on GitHubhttps://github.com/hlorus/CAD_Sketcher/issues/447#issuecomment-2327267749, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFODCWTSWQRCSKOG5YDNL3DZUYEYZAVCNFSM6AAAAABDHFIVJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGI3DONZUHE. You are receiving this because you were mentioned.Message ID: @.***>

dtremain commented 1 month ago

I'm using blender 4.2.1, Windows 10

I created a sketch, added two 4 x 10 rectangles, selected Mesh, turned off fill, renamed object, and tried to Leave the sketch, and got the attached error message.

I tried not renaming the object and got the same error.

David Tremain

From: KoDeltaS @.> Sent: Tuesday, September 3, 2024 3:29 PM To: hlorus/CAD_Sketcher @.> Cc: dtremain @.>; Mention @.> Subject: Re: [hlorus/CAD_Sketcher] [BUG] Generated geometry is incorrect and cannot be properly extruded using the solidify modifier (Issue #447)

Hi @wipmatehttps://github.com/wipmate , @dtremainhttps://github.com/dtremain , @jmsunserihttps://github.com/jmsunseri , @hlorushttps://github.com/hlorus , I tried to reproduce your issues and found a solution that works and the reason causing the problem.

The problem comes from the fact that Fill Shape doesn’t work well (it’s probably like a simple F in Edit Mode).

Solution: -Update the sketches by unchecking Fill Shape. -Exit the sketch. -Duplicate your mesh (if you go back to sketch mode, the changes will be lost). -Select the copied mesh, in Edit Mode (select everything with A) use ALT + F to fill. If you have complex geometry and ALT + F doesn’t work, create face "islands" manually.

I think it would be advisable to recommend using a step-by-step workflow:

-Sketch for basic geometries -Sketch of shapes to use as booleans

F_Bug.png (view on web)https://github.com/user-attachments/assets/6f91dc2e-942a-48d7-912f-0d485e7e30b6 Cross_Islands.png (view on web)https://github.com/user-attachments/assets/9898820e-a4ce-4def-bd86-93abfb5a41bc Cross_Z.png (view on web)https://github.com/user-attachments/assets/bb303ba6-cf29-41b9-849f-370e0d65cfda

— Reply to this email directly, view it on GitHubhttps://github.com/hlorus/CAD_Sketcher/issues/447#issuecomment-2327267749, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFODCWTSWQRCSKOG5YDNL3DZUYEYZAVCNFSM6AAAAABDHFIVJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGI3DONZUHE. You are receiving this because you were mentioned.