search

hlrs-vis / covise

Collaborative Visualization and Simulation Environment, OpenCOVER and OddLOT
http://www.hlrs.de/covise/
187 stars 87 forks source link

Stack overflow in RWCoviseASCI using SETELEM #13

Closed degasus closed 4 years ago

degasus commented 9 years ago

Ausnahmefehler bei 0x00007FF612039D07 in RWCoviseASCII.exe: 0xC00000FD: Stack overflow (Parameter: 0x0000000000000001, 0x00000024E5423000)

Ich vermute dass die 100k Zeiger in https://github.com/hlrs-vis/covise/blob/master/src/module/general/RWCoviseASCII/RW_ASCII.cpp#L770 nicht in den Windows Stack passen. std::vector?

Beispieldatei gibt es unter: https://paste.selfnet.de/BjQ5K/

uwewoessner commented 4 years ago

fixed it

degasus commented 4 years ago

Thanks. I'd suggest to also replace all char buffer[100000]; with std::vector<char> buffer(100000);. 100kB should fit on the stack (instead of the 800kB of those pointers), but it is still bad practise.

Sadly I can't test it any more, as I've left the project one and a half year ago.