search

hlship / tapx

Extensions to Tapestry 5
http://tapestry.formos.com/projects/tapx/
29 stars 7 forks source link

Embrace JDK 1.5 compatibility #22

Closed jochenberger closed 13 years ago

jochenberger commented 13 years ago

Source and target compatibility are set to 1.5 in the build file but there are several occurrences of @Override annotations on interface method implementations. I'll happily provide a patch/pull request but I wanted to make sure that you still intend to use 1.5 as the source level.

hlship commented 13 years ago

TapX isn't limited the way Tapestry is ... there's no reason for you to submit patches if you'd rather contribute directly. No votes, I can just do it by fiat ... its my own little project. However, you must do so with the knowledge that much of TapX will eventually be repackaged and refacted into Apache Tapestry, with the ASF copyright.

On Fri, Mar 18, 2011 at 12:40 AM, jochenberger reply@reply.github.com wrote:

Source and target compatibility are set to 1.5 in the build file but there are several occurrences of @Override annotations on interface method implementations. I'll happily provide a patch/pull request but I wanted to make sure that you still intend to use 1.5 as the source level.

Reply to this email directly or view it on GitHub: https://github.com/hlship/tapx/issues/22

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast!

(971) 678-5210 http://howardlewisship.com

jochenberger commented 13 years ago

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go. And, ASL is fine by me.

hlship commented 13 years ago

No, I'm keen for keeping 1.5 compatibility.

On Mon, Apr 4, 2011 at 1:33 AM, jochenberger reply@reply.github.com wrote:

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go. And, ASL is fine by me.

Reply to this email directly or view it on GitHub: https://github.com/hlship/tapx/issues/22#comment_952938

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast!

(971) 678-5210 http://howardlewisship.com

hlship commented 13 years ago

You now have direct commit rights. Please try to keep the copyright headers up to date.

On Mon, Apr 4, 2011 at 9:24 AM, Howard Lewis Ship hlship@gmail.com wrote:

No, I'm keen for keeping 1.5 compatibility.

On Mon, Apr 4, 2011 at 1:33 AM, jochenberger reply@reply.github.com wrote:

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go. And, ASL is fine by me.

Reply to this email directly or view it on GitHub: https://github.com/hlship/tapx/issues/22#comment_952938

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast!

(971) 678-5210 http://howardlewisship.com

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast!

(971) 678-5210 http://howardlewisship.com

jochenberger commented 13 years ago

Thanks. Sorry, that confused me so much that I just pushed a branch to the wrong remote. I hope, I didn't break anything. Should be okay again.

hlship commented 13 years ago

Convert code to use JDK 1.5 semantics for use of @Override annotation (on extended methods of super-classes, not implemented interface methods)

Closed by eea1c9b3a0c0978013e2f9a2051937bf86ad469c