Open joostschouten opened 13 years ago
I thought I had manually tested that. The return is there because the element.click() call is expected to re-invoke this method (as the listener for the click event) and on the second pass drop down to window.location assignment. I'll recheck if this works for me ... I probably was testing in Chrome. If you remove the "return" statement, I believe it will break the Ajax use case. Sometimes I hate HTML.
I had the problem with FF5.0.1. Without the return my usecases work for ajax and non ajax in FF5, chrome, IE7,8,9. But now you mention it, I did seem to have a problem in IE i needed to investigate where sometimes I got exceptions indicating I was deleting an already deleted item (confirm on delete). Which could indicate a double call which might be related to the second invocation not quite working as it should without the return. I'll dive into it a bit more. Looking forward to hearing your findings as well. And I agree, cross browser stuff is not my favorite activity ;-)
In firefox the confirm works good on ajax updates but not if the underlying link updates the whole page. Chrome works well. This is due to the following (see arrows):
Any reason why the return is there? Without it all seems to work for me.
This patch did the trick for me: