search

hltcoe / rebar

Other
1 stars 0 forks source link

support protobuf riak api #2

Closed maxthomas closed 10 years ago

maxthomas commented 11 years ago

Our protobuf version is 2.5.0 but the pb client only supports 2.4.1. this causes an exception when attempting to connect with the pb client

need to resolve this to use faster pb client instead of http as is now.

twolfe18 commented 11 years ago

I think this also explains some error that I occasionally get when reading concrete objects:

java.lang.VerifyError: class edu.jhu.hlt.concrete.Concrete$KnowledgeGraph overrides final method getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet;

http://stackoverflow.com/questions/16130886/protobuf-2-5-0-bug

Do you have a plan to fix this?

fmof commented 11 years ago

It should also explain this (closed) issue: https://github.com/hltcoe/concrete-agiga/issues/2. The fix for that was to upgrade to 2.5 (which might hinder integration?).

maxthomas commented 11 years ago

I don't have time to take a look at this any time soon.

In the meantime, make sure you're just using 2.5.0 in your dependencies (really don't need any pb dependencies if using concrete - it has them already). If you have 2.4.1 or other versions in your dependencies, you'll get issues.

We don't really want to downgrade - 2.5.0 offers ~25% faster message parsing.

2013/6/17 fmof notifications@github.com

It should also explain this (closed) issue: hltcoe/concrete-agiga#2https://github.com/hltcoe/concrete-agiga/issues/2. The fix for that was to upgrade to 2.5 (which might hinder integration?).

— Reply to this email directly or view it on GitHubhttps://github.com/hltcoe/rebar/issues/2#issuecomment-19545788 .

vandurme commented 11 years ago

Yes, this is not a priority: we can even live with disk-based access to Concrete for the moment, as we are doing minimal writes, just reads from a (mostly) static collection. For now let's cross fingers that Riak updates its support by the time we come back around to this.

On Mon, Jun 17, 2013 at 11:40 PM, max notifications@github.com wrote:

I don't have time to take a look at this any time soon.

In the meantime, make sure you're just using 2.5.0 in your dependencies (really don't need any pb dependencies if using concrete - it has them already). If you have 2.4.1 or other versions in your dependencies, you'll get issues.

We don't really want to downgrade - 2.5.0 offers ~25% faster message parsing.

2013/6/17 fmof notifications@github.com

It should also explain this (closed) issue: hltcoe/concrete-agiga#2< https://github.com/hltcoe/concrete-agiga/issues/2>. The fix for that was to upgrade to 2.5 (which might hinder integration?).

— Reply to this email directly or view it on GitHub< https://github.com/hltcoe/rebar/issues/2#issuecomment-19545788> .

— Reply to this email directly or view it on GitHubhttps://github.com/hltcoe/rebar/issues/2#issuecomment-19589223 .