search

hluisson / eslint-plugin-jsx-expressions

Rules for safe logical expressions in JSX
95 stars 12 forks source link

Remove React Native links #10

Closed karlhorky closed 1 year ago

karlhorky commented 1 year ago

Seems like React Native doesn't error out with empty strings anymore? https://twitter.com/karlhorky/status/1576958348288987137

Feel free to close if I'm wrong on this somehow. If I'm wrong, sorry for the noise!

karlhorky commented 1 year ago

Ok, so I didn't really get a clear answer from any maintainers there, but I just started a new React Native app just now (npx react-native init with react-native@0.70.1) to confirm this and confirmed empty strings outside of <Text> components do not cause this error:

Screen Shot 2022-10-04 at 13 10 49

Whereas a string with content in it does (this also applies to numbers):

Screen Shot 2022-10-04 at 13 14 34

Repo: https://github.com/karlhorky/react-native-empty-string-outside-text-component

karlhorky commented 1 year ago

So it probably still makes sense to link to those React Native links, closing.