Open vr8hub opened 3 months ago
- I understand that
<i>
tags should (almost) always have semantics. Would that include the examples below, and if so, how would you suggest classifying them? In Chap 12, the Bon Marché (department store) and Louvre (museum) are italicized. In Chap 16, Cornaro is italicized in reference to the book authored by Cornaro (you referenced this one in your feedback). In Chap 18, the Life Travellers Society is italicized as an insurance company.- In a couple of blockquotes, there are line breaks in the scans that are dictated by the width of the page. I thought in an ebook format it would be better to remove these where logical, but wanted to confirm if I should leave all those breaks in place to match the scans.
- In commit e640111, I removed single quotes from character names (characters referenced from a book/opera). Is this an editorial change?
Let's keep things related to the review here, so everything is in one place.
Just checking in to see how it's going.
Thanks Vince for checking in. I've made it through your feedback and the necessary rebasing. I'm just wanting to do a final proofread, and this week got very busy for me. I should come back to you in the next 2-3 days when I'm ready for you to take another look.
No worries, take your time.
I've made it through my proofread, and when you have time, I would be ready for you to take another look at my repo. Thanks in advance!
These are haphazard, as I noted them as I found them.
<b>
.<br/>
) are generally for breaks within a sentence (excluding poetry). Therefore there should be three<p>
s in the blockquote.<q>
(for inline quotation) rather than<em>
.<strong>
, not<em>
.