Review 2

[vr8hub]

Great, Harry, a few additional (and some old) things.

• [x] Tags, whether language, italics, spans, etc., go inside quotes, not outside them, so, e.g. “<span xml:lang…>Blah blah”, etc. Lint catches this for italics, we need to catch it for spans as well.
• [x] As mentioned last time, the standard SE verse/song CSS is still not present, see SEMoS 7.5, esp. 7.5.8.
• [x] We don't center blockquotes by default, so that CSS should be removed. Nor do the telegrams need the 4em margins; our normal blockquote horizontal margins are usually fine. The telegrams also don't need to be justified. If particular blockquotes need to be centered (e.g. the book in ch. 9), then target those specific blockquotes in CSS.
• [x] We don't need a class when an appropriate HTML element already exists. Blockquotes, like several other sectioning elements, can have a header element. That is what should be used for the telegram headers, with the appropriate CSS that targets them (blockquote header). In the case of the telegram split across two blockquotes in ch. 1, the first one is the header, and the second one is the body.
• [x] Similarly, the headline class isn't needed; the span should just be a <b> as it was before. The single blockquote that needs the formatting can easily be targeted with #chapter-13 blockquote (as it is the only blockquote in the chapter).
• [x] Publication tags go on italics, not block elements, so the long title in ch. 9 should be italicized just like all of the other publications, operas, etc. are. (Because this is a publication, not generic formatting, it is an exception to the "if the entire element is formatted the same…" guideline.) As I mentioned last time, only the first sentence is the actual title.
• [x] Also, we do titlecase titles if they're in English, so that should be titlecased in an editorial commit. (And then the ignore record is not needed.)
• [x] I did not see this last time: negro(es) should be capitalized, editorial.
• [x] Also missed last time: the Latin quote in ch. 11 is from Ovid's Tristia, so should be formatted as verse.
• [x] The italics changed to emphasis in ch. 9 do not appear to be emphasis. (As with the other added emphasis that weren't in the scans, the presence of an exclamation point does not necessarily mean emphasis, i.e. italics.) That is, the words don't appear to be have been italicized due to emphasis, but because they were non-English phrases. Since they are in M-W, they don't need any tags at all.
• [x] As above, when SEMoS is explicit, we follow it regardless of the source. So, the second instance of yemetchik should be tagged (as it was), regardless of whether it is italicized in the scans.
• [x] Commit 7956738, labeled "Remove italics from dictionary-defined word," also has two punctuation changes in it. Again, please make sure that a single commit contains only a single type of work. The punctuation changes are fixing transcription errors, and are unrelated to the other change.
• [x] Just as a courtesy for others looking at the CSS, we try to keep "standard" SE CSS at the top, with production-specific "custom" CSS at the bottom. E.g., the era, blockquote[xml|lang], and q and the verse/song CSS that needs to be added are "standard."
• [x] The m-009 ignore entry isn't needed; Alex will fix the URL when he adds it to SE. (That's my fault, I told you to fix/ignore all of them, but I didn't remember that this was one of the errors.)

[hlund05]

Thanks again for the review. Most of these were fairly quick to fix, but I have a few follow-up questions:

1. Apologies, but I'm still unclear on the standard SE verse/song CSS to be included. Is it as simple as including something like this in local.css?

[epub|type~="z3998:song"], [epub|type~="z3998:verse"]{ text-align: initial; text-indent: 0; }

2. Regarding your feedback, "the second instance of yemetchik should be tagged (as it was), regardless of whether it is italicized in the scans" -- I think I internalized SEMoS 8.2.9.3 to mean that only the first instance of a non-English word needs to be italicized, which I see is not correct. I know there are other places where I did not add italics because of this. Just to confirm, should I find all the words that have been tagged as non-English, and italicize them at every instance? I don't believe any will occur so frequently that they will be "distracting" per SEMoS.

3. Regarding non-English words generally, if a word is found in MW as a variant (for example, "pilau" points to the definition for "pilaf"), is this sufficient to consider it an English word and skip italics? Should I update the spelling to the common version?

[vr8hub]

1. Did you look at the link I gave you? The section I mentioned, 7.5.8, has all of the CSS in the example.
2. Correct. If it's non-English and not in M-W, it's italicized, unless it gets too many (which, as you note, rarely happens).
3. Right, it doesn't just point to it, it's listed as a variant, so yes, it doesn't need tags, and the spelling can stay as is.

[hlund05]

Follow-up to #3, since you may have drawn a distinction in your response: "Douma" directs to the definition of "duma," but it's NOT listed as a variant there. Same treatment or different? And lastly, the word "borchtch" is not found in M-W, but in the book it's clearly an alternate spelling of "borscht," the soup dish. What is the appropriate treatment in this case? Thanks.

[vr8hub]

M-W says that douma is a variant spelling of duma, so I would leave it as is. (This is an inexact science. :) Borscht can definitely be modernized in an editorial commit.

[hlund05]

I have addressed all the issues in this thread now. I have a new issue (example below from Chap 6) where quotation marks are appearing on new lines in song/verse blockquotes, due to CSS and span tags being moved inside quotes. Should I remove these quotation marks? Assuming I have implemented the song/verse CSS correctly (still not confident on this point), deleting the quotes would seem to be the only solution.

“ Nec tecum possum vivere sine te, ”

[vr8hub]

Sorry, the confusion is understandable. My comment above said tags go inside quotes, i.e. language tags, epub:type tags, etc., regardless of whether they're on italics or on spans. But there are no tags on verse/song spans, and the spans there are for an entirely different reason. In the same section of SEMoS that had the sample CSS (7.5.8), what immediately followed the CSS was a properly formatted poem. In short, the formatting you had before for those were perfectly fine. Your song/verse CSS looks good! For the blockquote p margin, we don't want margin between two paragraphs in a blockquote, we want margin between the header and the text of a blockquote, so that margin would be a margin-bottom on blockquote header. (And we usually use 1em for that margin.) I haven't looked at everything else; I'll do so later today.