search

hlwhl / webview_cef

WebView for Flutter Desktop Apps using CEF(Chromium Embedded Framework) [Work in Progress]
Apache License 2.0
189 stars 54 forks source link

NavigationDelegate & NavigationDecision #145

Closed patel0712 closed 3 weeks ago

patel0712 commented 2 months ago

Hey, @SinyimZhi @hlwhl @BullsEye34 @Doflatango @uppet

I try with diffferent logic for NavigationDelegate & NavigationDecision and i think i'm close to this but there's some error so i think the code is not properly managed also i'm fresher in this.

if you have some time then please review it.

Error

`(webview_cef_demo:83150): Gtk-WARNING **: 19:33:57.888: gtk_disable_setlocale() must be called before gtk_init() MESA-INTEL: warning: Performance support disabled, consider sysctl dev.i915.perf_stream_paranoid=0

[0909/193357.995894:WARNING:angle_platform_impl.cc(48)] vk_utils.cpp:358 (GetAvailableValidationLayers): Vulkan validation layers are missing. WARN: vk_utils.cpp:358 (GetAvailableValidationLayers): Vulkan validation layers are missing. [0909/193358.038484:WARNING:sandbox_linux.cc(393)] InitializeSandbox() called with multiple threads in process gpu-process. [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'package:webview_cef/src/webview.dart': Failed assertion: line 87 pos 12: 'value': is not true.

0 _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)

1 _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)

2 WebViewController.setNavigationDelegate (package:webview_cef/src/webview.dart:87:12)

3 DashboardController.initPlatformState (package:webview_cef_demo/dashboard_controller.dart:60:24)

`
SinyimZhi commented 4 weeks ago

I have seen too many inconsistent text formatting changes in this PR, which increases the difficulty of the review. The third/ref directory is planned to unify the CEF versions across different platforms in the future and reduce the size of pre built packages, so it is not recommended to delete it temporarily. Of course, if we can keep up with version updates in the future, we will no longer need this directory. What is the biggest change between this PR and the PR you cancelled? Or which code do you think is better? Can you cancel the changes related to text formatting?