search

hlwhl / webview_cef

WebView for Flutter Desktop Apps using CEF(Chromium Embedded Framework) [Work in Progress]
Apache License 2.0
189 stars 54 forks source link

Fix recent changes for Linux and add pipeline for testing Linux builds #157

Closed cadivus closed 1 month ago

cadivus commented 1 month ago

Recent changes make me get these errors:

/webview_cef/example/linux/flutter/ephemeral/.plugin_symlinks/webview_cef/common/webview_js_handler.cc:180:21: error: enumeration value 'UNKNOWN' not handled in switch [-Werror,-Wswitch]
/webview_cef/example/linux/flutter/ephemeral/.plugin_symlinks/webview_cef/common/webview_plugin.cc:434:24: error: 4 enumeration values not handled in switch: 'VTYPE_INVALID', 'VTYPE_NULL', 'VTYPE_BINARY'... [-Werror,-Wswitch]
/webview_cef/example/linux/flutter/ephemeral/.plugin_symlinks/webview_cef/common/webview_plugin.cc:430:41: error: variable 'retValue' is uninitialized when used here [-Werror,-Wuninitialized]

This PR fixes that. In addition, it adds a Linux pipeline for testing future changes on Linux.

cadivus commented 1 month ago

I guess the pipeline does not run before merging for security reasons. You can see it running here:
https://github.com/cadivus/webview_cef/pull/2

SinyimZhi commented 1 month ago

That's great. Let us try if the pipeline can work or not. And i don't have permission to push release on pub.dev, this will take some time. @hlwhl

cadivus commented 1 month ago

@SinyimZhi Maybe @hlwhl can set this up:
https://github.com/hlwhl/webview_cef/pull/158 This would allow maintainers to just create a new tag for publishing so that no local setup or permissions are needed anymore.

hlwhl commented 4 weeks ago

@SinyimZhi @cadivus Publish by tag action has been set up.