Article slides: support static content to improve LHS - Githubissues

hlxsites / 24life

Apache License 2.0

0 stars 0 forks source link

Article slides: support static content to improve LHS #187

Closed synox closed 11 months ago

synox commented 11 months ago

Test URLs:

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

[ ] Re-run PSI Checks

aem-code-sync[bot] commented 11 months ago

Page	Scores	Audits	Google
/

github-actions[bot] commented 11 months ago

:small_orange_diamond: 1 visual difference detected

/block-library/blocks/article-hero-video (main vs branch)
Expected an image 1344px by 2959px, received 1280px by 2959px. 218649 pixels (ratio 0.06 of all image pixels) are different.

The diff images are attached in the artifact

aem-code-sync[bot] commented 11 months ago

Page	Scores	Audits	Google
/

aem-code-sync[bot] commented 11 months ago

Page	Scores	Audits	Google
/

github-actions[bot] commented 11 months ago

:small_orange_diamond: 2 visual differences detected

/focus/2019/the-change-master-john-berardis-second-act-will-help-you-too (main vs branch)
Expected an image 1344px by 9707px, received 1280px by 9707px. 601121 pixels (ratio 0.05 of all image pixels) are different.
/block-library/blocks/article-hero-video (main vs branch)
Expected an image 1344px by 2959px, received 1280px by 2959px. 787379 pixels (ratio 0.20 of all image pixels) are different.

The diff images are attached in the artifact

github-actions[bot] commented 11 months ago

:small_orange_diamond: 2 visual differences detected

/focus/2019/the-change-master-john-berardis-second-act-will-help-you-too (main vs branch)
Expected an image 1344px by 9707px, received 1280px by 9707px. 604023 pixels (ratio 0.05 of all image pixels) are different.
/block-library/blocks/article-hero-video (main vs branch)
Expected an image 1344px by 2959px, received 1280px by 2959px. 138266 pixels (ratio 0.04 of all image pixels) are different.

The diff images are attached in the artifact

github-actions[bot] commented 11 months ago

:small_orange_diamond: 2 visual differences detected

/focus/2019/the-change-master-john-berardis-second-act-will-help-you-too (main vs branch)
Expected an image 1344px by 9707px, received 1280px by 9707px. 598077 pixels (ratio 0.05 of all image pixels) are different.
/block-library/blocks/article-hero-video (main vs branch)
Expected an image 1344px by 2959px, received 1280px by 2959px. 138266 pixels (ratio 0.04 of all image pixels) are different.

The diff images are attached in the artifact