hlxsites / 24petwatch

Franklin site for 24petwatch.com
Apache License 2.0
0 stars 4 forks source link

feat: add martech plugin to connect to analytics and target #153

Open ramboz opened 3 months ago

ramboz commented 3 months ago

This PR adds integration with Target, Launch & ACDL via the martech library. It also moves the Analytics instrumentation to the martech library, and creates a more generic loader to combine the GTM and WebSDK logic and isolate it from the main scripts.js file.

At a high level:

Test URLs:

aem-code-sync[bot] commented 3 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [0291d5b](https://github.com/hlxsites/24petwatch/commit/0291d5b5d1d966cb8ef69f05dd045d850b21ac25) :white_check_mark: (latest) * [668c1a0](https://github.com/hlxsites/24petwatch/commit/668c1a04c5a75bf4ab5fc43bd726b7a932a38422) :white_check_mark: * [37f98f1](https://github.com/hlxsites/24petwatch/commit/37f98f1a314f1d17501177a6d5f8d55a645b9d92) :white_check_mark: * [4ffb282](https://github.com/hlxsites/24petwatch/commit/4ffb282fc600f9f38ff2a7e34dcc98cbbf8ed14d) :white_check_mark: * [67b8ecf](https://github.com/hlxsites/24petwatch/commit/67b8ecf2a468ecac54f1abb70549b55d403101ae) :white_check_mark: * [4874a59](https://github.com/hlxsites/24petwatch/commit/4874a59c40103b61e22bdaa015324660ff974b6f) :white_check_mark:
aem-code-sync[bot] commented 3 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
ramboz commented 3 months ago

@fe-lix- @ekremney @bohnertchris Since I did quite some heavy lib-analytics.js refactoring for this, if you know the various analytics events they were tracking before, could you perform a quick sanity check to make sure we didn't lose anything along the way?

ekremney commented 3 months ago

@ramboz it has been almost 1 year since the custom analytics events were implemented for this project. I am afraid I cannot recall all the details. The most important events were tracked by GA4 via trackGTMEvent