Closed cylevaldez closed 1 year ago
@cylevaldez could you please list the events required to be triggered, so that we can instrument the block to trigger the same.
<!-- The script tag should live in the head of your page if at all possible -->
<script type="text/javascript" async src="https://play.vidyard.com/embed/v4.js"></script>
<!-- Put this wherever you would like your player to appear -->
<img
class="vidyard-player-embed"
src="https://play.vidyard.com/"playerUUID".jpg"
data-uuid="playerUUID";
data-v="4"
data-type="inline"
/>
Not sure if the v4.js causes LHS to drop, but check it out.
@cylevaldez as per our discussion in yesterday's call, I've made the changes to render the video using vidyard js in https://github.com/hlxsites/accenture-newsroom/blob/vidyard/blocks/video/video.js#L13-L23
You can see the changes in this url
I'm adding the script v4.js to the head first, then waiting until that script is downloaded. Then adding the img with all the properties as per above. But still, the video isn't showing. Can you please check with Miko, what's missing in this change.
@ravkiran We can't access the url provided. I'm getting this issue
Is there a workaround for this?
Miko initially checked the code you provided, and it seems to be correct. It will be better to have the URL
@cylevaldez that's weird. Are you using this url https://vidyard--accenture-newsroom--hlxsites.hlx.page/drafts/ravi/accenture-interactive-expands-experience-led-transformation-services-in-southeast-asia-with-acquisition-award-winning-agency-entropia
Is it asking the login?
You need to login to Accenture sharepoint to access these links.
@ravkiran Yes, I'm using that URL. It is also asking for a login. Not sure, but maybe I don't have access to that Accenture sharepoint. I'll ask for access
@ravkiran I was able to open the URL now. Miko suggested to try to change the image tag to the following for the video to render:
From:
To:
@cylevaldez sorry, didn't pay much attention to the /
in the uuid, fixed now
You can check in https://vidyard--accenture-newsroom--hlxsites.hlx.page/drafts/ravi/accenture-interactive-expands-experience-led-transformation-services-in-southeast-asia-with-acquisition-award-winning-agency-entropia But still the video isn't rendering. Can you please check?
@ravkiran We suggest to try two things:
Can we try following the order of the attributes as mentioned in the vidyard document? (Class attribute will be first, then src, and so on) As we are not sure on how the Vidyard API script was coded on their end.
Can we also try to remove the async or set it to false for the Vidyard JS?
@cylevaldez Its very unlikely that any public API can read the ordering of attributes in the html, anyways, I've made the change requested but still not working. Please check https://vidyard--accenture-newsroom--hlxsites.hlx.page/drafts/ravi/accenture-interactive-expands-experience-led-transformation-services-in-southeast-asia-with-acquisition-award-winning-agency-entropia
If this is taking time in to & fro, we can meet in a call at 10/09 7 PM PST.
@ravkiran Sure, we can have the call
Priority: 2 - High
Steps to Reproduce: NOTE: This applies for all vidyard videos
Expected Result: Analytics video milestones are triggered
Actual Result: Analytics video milestones are not triggered