Closed jjjaspher closed 9 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits |
---|---|---|
/ |
@jjjaspher I took a closer look at perf and it looks to me to be CLS. I think if we can add a min-height on .newslist-item
that should remove most if not all of the cls (that height will need to be a bit of a guess, and probably different across breakpoints).
One option would be to add that min-height only while the description is loading, so something like:
description-pending
or whatever
- I think long description is used by search. can we change that to just use description instead?
Hi @shsteimer , our description column is not a clean data, it was being cutoff from many articles.
For the CLS issue, I implemented the min-height for both newslist card and search result. We're now back to 100 performance score. Please let me know if there are other concern. Thanks!
@jjjaspher everything looks good and is good to merge IMHO.
I do think we still need to do something about search as that uses the long description from the query index at https://github.com/hlxsites/accenture-newsroom/blob/main/blocks/newslist/newslist.js#L112
but can probably do that in a separate PR
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix https://github.com/hlxsites/accenture-newsroom/issues/480
Test URLs: