hlxsites / aem-boilerplate-commerce

Use this repository template for new AEM+Commerce projects.
https://main--aem-boilerplate-commerce--hlxsites.aem.live
Apache License 2.0
27 stars 21 forks source link

Update auth, order and account dropins #132

Closed Ferri0 closed 1 month ago

Ferri0 commented 1 month ago

Implemented changes:

This PR should resolve following Slack threads:

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [65927db](https://github.com/hlxsites/aem-boilerplate-commerce/commit/65927db2afca09b05e84b8c86823f670c1f0ea8a) :arrows_counterclockwise: (latest) * [d84d3e3](https://github.com/hlxsites/aem-boilerplate-commerce/commit/d84d3e348a3af8d5b8136080e8ca7eb270639fde) :white_check_mark: * [e0e9214](https://github.com/hlxsites/aem-boilerplate-commerce/commit/e0e92140e8e30383c16b1fc5a43e21462d0e48b2) :white_check_mark: * [36b5a39](https://github.com/hlxsites/aem-boilerplate-commerce/commit/36b5a39f3efaa5968c445f0e0c095be0f27569f9) :white_check_mark: * [c4828fb](https://github.com/hlxsites/aem-boilerplate-commerce/commit/c4828fbbb2d3cf7053fd19efb16147f1a7446c44) :white_check_mark: * [de9e6fa](https://github.com/hlxsites/aem-boilerplate-commerce/commit/de9e6fa0856ce075ed2fdc11ea53427cb5b7bfb2) :white_check_mark: * [956baee](https://github.com/hlxsites/aem-boilerplate-commerce/commit/956baee03a64ab67db624cf7ca4b9e1de30df2b5) :white_check_mark: * [6174988](https://github.com/hlxsites/aem-boilerplate-commerce/commit/61749880f8e7aae1b267997544f779244e45c558) :white_check_mark: * [15f9997](https://github.com/hlxsites/aem-boilerplate-commerce/commit/15f9997c5166a16b6558731fd6a46a03a0f69aa4) :white_check_mark: * [cc68edf](https://github.com/hlxsites/aem-boilerplate-commerce/commit/cc68edf05edd8306581a02c207d4f9151feb89c9) :white_check_mark: * [37cafb4](https://github.com/hlxsites/aem-boilerplate-commerce/commit/37cafb4ae488680e324060f13a86f219624b1873) :white_check_mark: * [2a6c451](https://github.com/hlxsites/aem-boilerplate-commerce/commit/2a6c4511ce535c9928382177581da2f5d3863344) :white_check_mark: * [49cfa08](https://github.com/hlxsites/aem-boilerplate-commerce/commit/49cfa087b549096b5f1e463a7ab6a4b53530bcb1) :white_check_mark: * [73160a1](https://github.com/hlxsites/aem-boilerplate-commerce/commit/73160a12ab4a65b42e9b2cfff8b9c837f0578b5e) :white_check_mark: * [88b2ce3](https://github.com/hlxsites/aem-boilerplate-commerce/commit/88b2ce3a3bb3cb73e284381783281edeedcc1667) :white_check_mark: * [207dd1a](https://github.com/hlxsites/aem-boilerplate-commerce/commit/207dd1a3e1f705a03b9afc15d6ca5f8d54a2fd96) :x: * [51c8614](https://github.com/hlxsites/aem-boilerplate-commerce/commit/51c8614fdab5c2bb5c3ee46e585670cad8d9a67e) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
:iphone: / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sirugh commented 1 month ago

How is this last commit, 36b5a39, just of the files, without a package-lock or package.json update? Seems if you are updating the postinstall copied assets, the lockfile would change at least.

KostiantynFandeliuk commented 1 month ago

How is this last commit, 36b5a39, just of the files, without a package-lock or package.json update? Seems if you are updating the postinstall copied assets, the lockfile would change at least.

@sirugh Sorry, that was my mistake. I pushed new changes to this branch without realizing you were working with it and wanted to test account dropin. I've reverted the changes with a new commit. I apologize once again for this!

CC @Ferri0

sirugh commented 1 month ago

I think you misunderstand @KostiantynFandeliuk :) I was just noting that when you push a commit with changed __dropins__/ files, I would also expect that package-lock is changed.

As for working wth this PR, I am just trying to fix the tests for y'all. You are free to push changes here, I'll keep focusing on the commit prior, c4828fb.