Closed Ferri0 closed 1 month ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
How is this last commit, 36b5a39, just of the files, without a package-lock or package.json update? Seems if you are updating the postinstall copied assets, the lockfile would change at least.
How is this last commit, 36b5a39, just of the files, without a package-lock or package.json update? Seems if you are updating the postinstall copied assets, the lockfile would change at least.
@sirugh Sorry, that was my mistake. I pushed new changes to this branch without realizing you were working with it and wanted to test account dropin. I've reverted the changes with a new commit. I apologize once again for this!
CC @Ferri0
I think you misunderstand @KostiantynFandeliuk :) I was just noting that when you push a commit with changed __dropins__/
files, I would also expect that package-lock is changed.
As for working wth this PR, I am just trying to fix the tests for y'all. You are free to push changes here, I'll keep focusing on the commit prior, c4828fb.
Implemented changes:
This PR should resolve following Slack threads:
Test URLs: