hlxsites / aem-boilerplate-commerce

Use this repository template for new AEM+Commerce projects.
https://main--aem-boilerplate-commerce--hlxsites.aem.live
Apache License 2.0
27 stars 21 forks source link

Add PDP events #68

Closed alandana closed 5 months ago

alandana commented 5 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [a22ecea](https://github.com/hlxsites/aem-boilerplate-commerce/commit/a22ecea9eb88c9f2efd60847ebdc6a607d79c2e5) :arrows_counterclockwise: (latest) * [e9e0533](https://github.com/hlxsites/aem-boilerplate-commerce/commit/e9e0533627477280744dad376ce2b86a208ef915) :white_check_mark: * [6632f14](https://github.com/hlxsites/aem-boilerplate-commerce/commit/6632f14379d221fbb7c85c5e2f0ff1fdfb0f5919) :white_check_mark: * [7801527](https://github.com/hlxsites/aem-boilerplate-commerce/commit/780152799ac919e7a9d8c3199c9bf8c64caac110) :white_check_mark: * [58f3d6c](https://github.com/hlxsites/aem-boilerplate-commerce/commit/58f3d6cd90637a0986c12cd8da6439a5f1050fb8) :white_check_mark: * [358e596](https://github.com/hlxsites/aem-boilerplate-commerce/commit/358e596cc042ba4885e321bbdd54c32c917b8f9a) :white_check_mark: * [ee835ea](https://github.com/hlxsites/aem-boilerplate-commerce/commit/ee835ea19f00687f54d6e37da8362127ba2cd4b9) :white_check_mark: * [fccf010](https://github.com/hlxsites/aem-boilerplate-commerce/commit/fccf010c329b08579af677198863787e3229ca24) :white_check_mark: * [2c2b9a2](https://github.com/hlxsites/aem-boilerplate-commerce/commit/2c2b9a2962e2de1921efe3ef6471fd2578a5223b) :white_check_mark: * [eae07b7](https://github.com/hlxsites/aem-boilerplate-commerce/commit/eae07b737f254222ec0758f36d352a2b87f0e60b) :white_check_mark: * [9cde325](https://github.com/hlxsites/aem-boilerplate-commerce/commit/9cde325c81e662bd85f918f176d0e3c511015446) :white_check_mark: * [4e5410a](https://github.com/hlxsites/aem-boilerplate-commerce/commit/4e5410a88617d2d43299655ace011799504a5332) :white_check_mark: * [338b311](https://github.com/hlxsites/aem-boilerplate-commerce/commit/338b311f3a0b275d9baa189b4d95f999d33c278e) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/products/abominable-hoodie/MH09 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
alandana commented 5 months ago

According to the schema, productId should be a number, not a string. Is there a way to customize the canonicalUrl? As in the context of Edge Delivery the canonical URL is usually different than what's returned by the API.

image

@herzog31 What do you mean by customizing the canonicalURL? From the dropin or from EDS? I realized I mapped the canonicalUrl to urlKey, but the API response also provides url. Would that be better?