search

hlxsites / airindia

Github repo for Airindia EDS site
Apache License 2.0
0 stars 0 forks source link

Add alt attributes and improve lighthouse scores #50

Closed adobenitesh closed 5 months ago

adobenitesh commented 7 months ago

Fix #33 Fix #41 Fix #42

Test URLs:

aem-code-sync[bot] commented 7 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [e19b501](https://github.com/hlxsites/airindia/commit/e19b5010e1fb1bd685aeb56d68d9eb0fbdfcd6cb) :white_check_mark: (latest) * [835eb30](https://github.com/hlxsites/airindia/commit/835eb304f74211228c079f501ee4b2bccab4e401) :white_check_mark: * [254a9e9](https://github.com/hlxsites/airindia/commit/254a9e90a1ecd6d702934446edbbff773b68b5eb) :white_check_mark: * [14d367c](https://github.com/hlxsites/airindia/commit/14d367c44b36ccacb7d0d9124dd7ac73716422e9) :white_check_mark: * [93bb1cb](https://github.com/hlxsites/airindia/commit/93bb1cbfdc14825383f4714f8497c38f880fd620) :white_check_mark: * [653caf7](https://github.com/hlxsites/airindia/commit/653caf7fca82cf059e6ffd6f3090db19a7ba61c2) :white_check_mark: * [297dd86](https://github.com/hlxsites/airindia/commit/297dd866abaef499cfb6e1afe95e1f1cea6812d9) :white_check_mark: * [c47969d](https://github.com/hlxsites/airindia/commit/c47969d1f78b409d732cbc4f90603fb70094ecf8) :white_check_mark: * [da782c5](https://github.com/hlxsites/airindia/commit/da782c512d83c762873d8a16e296e4699c69fac3) :white_check_mark: * [7b8c8b8](https://github.com/hlxsites/airindia/commit/7b8c8b80639e2860d988d9dc45e06006295023d1) :white_check_mark: * [9cbf787](https://github.com/hlxsites/airindia/commit/9cbf7873526a0108590354f34ba3550c547c71f8) :white_check_mark: * [c331ac6](https://github.com/hlxsites/airindia/commit/c331ac6bfb41c213e0af18668332d65bb874ab93) :white_check_mark: * [07029c6](https://github.com/hlxsites/airindia/commit/07029c61070bd074d76afcd9373b10e7f0289d91) :white_check_mark: * [8fc117b](https://github.com/hlxsites/airindia/commit/8fc117b222b53ea32ff23db4ce9af04d62535078) :white_check_mark: * [c1e3542](https://github.com/hlxsites/airindia/commit/c1e3542b8cc606c38527f90b828f0e9918545525) :x: * [d777d2c](https://github.com/hlxsites/airindia/commit/d777d2c21197fc364f99129103eadf42dedea67a) :x: * [36db72a](https://github.com/hlxsites/airindia/commit/36db72a9d74446c52fbf5080cc93bfcfbfc90003) :x: * [48ce3a0](https://github.com/hlxsites/airindia/commit/48ce3a0a11752ee14851bb11b0d3022264333131) :x: * [ccb5f41](https://github.com/hlxsites/airindia/commit/ccb5f4123e0118350bfa1d16c3802bfcae1c7a39) :x: * [9baabac](https://github.com/hlxsites/airindia/commit/9baabac44e8952673ed596edf6969f549f5d6559) :x: * [46bc8c4](https://github.com/hlxsites/airindia/commit/46bc8c464406f3900c7da8cbd625f541ca64ff3a) :x: * [e713b9b](https://github.com/hlxsites/airindia/commit/e713b9b38d060eab6b576cadb363d917d0495722) :x: * [0c6ed98](https://github.com/hlxsites/airindia/commit/0c6ed989224bf0c567ceb363d813422569bcc009) :x: * [517f43b](https://github.com/hlxsites/airindia/commit/517f43bf867a781be8e748d0f5698165ae643903) :x: * [a4dc043](https://github.com/hlxsites/airindia/commit/a4dc043c8e2762f1d9916fa0a517436adf91a306) :x: * [c90f782](https://github.com/hlxsites/airindia/commit/c90f78268da718b57c50a629343d44fed5c7a713) :x: * [44aa38d](https://github.com/hlxsites/airindia/commit/44aa38dad638ee51cd23f8b107cd05a3df5d856b) :x: * [e286b26](https://github.com/hlxsites/airindia/commit/e286b264505600f372e18b062491f517b063c77a) :x: * [3e8499e](https://github.com/hlxsites/airindia/commit/3e8499ecda7c791ffc2e3468296c5a17bb90d455) :x: * [4ee05ea](https://github.com/hlxsites/airindia/commit/4ee05ea2c669761e5bcf498609acf1111cafd7ad) :x:
aem-code-sync[bot] commented 7 months ago
Page Scores Audits Google
/in/en/book/special-offers/global-connectivity PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
dipratap commented 5 months ago

The footer docx needs changes for this PR, since main is dependent on footer docx changes, I haven't published the footer changes yet (they are saved though in the docx so if previewed they will appear) so the footer in https://i-33-41--airindia--hlxsites.hlx.live/in/en/book/special-offers/global-connectivity will appear distorted currently.

dipratap commented 5 months ago

The footer looks broken. Not sure if its related to proposed changes but we should check

@sdmcraft Quoting my earlier comment here:

The footer docx needs changes for this PR, since main is dependent on footer docx changes, I haven't published the footer changes yet (they are saved though in the docx so if previewed they will appear) so the footer in https://i-33-41--airindia--hlxsites.hlx.live/in/en/book/special-offers/global-connectivity will appear distorted currently.

I can preview and publish the changes in footer doc after which the footer will look correct, but it will distort the main one until these PR changes are merged. Your thoughts?

dipratap commented 5 months ago

Temporary footer content docx added here and used in this branch. The footer will appear correct now.

Original footer doc to be replaced with the temporary doc just before PR merge.

dipratap commented 5 months ago

@sselvara Could you please review this?

dipratap commented 5 months ago

TODO post PR approval:

const footerPath = footerMeta.footer || '/drafts/divyansh/footer';