hlxsites / caesars-careers

caesars.com/careers on Adobe AEM Franklin
Apache License 2.0
0 stars 0 forks source link

fixed highlight and made it dynamic based on url #50

Closed amol-anand closed 1 year ago

amol-anand commented 1 year ago

Fix #5

🔗 Test URLs:

📝 Description:

Highlight menu items based on current URL and fixed the animation on the highlights

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
tmathern commented 1 year ago

Logo placement is off/misaligned:

Screenshot 2023-05-09 at 9 00 29 AM
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
amol-anand commented 1 year ago

Code LGTM - Do you want to look at the logo misalignment too in this PR?

I fixed that in the CSS.. which misalignment you talking about?

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
amol-anand commented 1 year ago

If you look at https://www.caesars.com/careers it's the same. the logo is not misaligned, it is intentionally bigger than the rest of the nav and stands out and overflows down the nav a bit overlaying the hero.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/careers SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/sms-terms-and-conditions SI FCP LCP TBT CLS PSI