search

hlxsites / danaher-ls-aem

AEM Franklin / Crosswalk site for DH Life Sciences
Apache License 2.0
2 stars 4 forks source link

1040 Topic's header ReBrand changes #1066

Closed amlan18041996 closed 1 month ago

amlan18041996 commented 2 months ago

Fix #1040

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [85e7ef2](https://github.com/hlxsites/danaher-ls-aem/commit/85e7ef2c62ec4d298d592e32196049fe8e498fad) :white_check_mark: (latest) * [e68e229](https://github.com/hlxsites/danaher-ls-aem/commit/e68e22947813557911ea094d2f4c82b8171dc9c3) :white_check_mark: * [c2c197b](https://github.com/hlxsites/danaher-ls-aem/commit/c2c197b5b0850c63278efdf95a8cddc8c0c0d3ec) :white_check_mark: * [634f9ac](https://github.com/hlxsites/danaher-ls-aem/commit/634f9ac5f76968fdda5100dfb4e7f62d7a880f28) :white_check_mark: * [3991a48](https://github.com/hlxsites/danaher-ls-aem/commit/3991a48c124c8a62c112a4286b26c02b53bef644) :white_check_mark: * [4070b4a](https://github.com/hlxsites/danaher-ls-aem/commit/4070b4ae3202c01ad9a850ba98a470710a2f8073) :white_check_mark: * [51867fd](https://github.com/hlxsites/danaher-ls-aem/commit/51867fdaa8e99597ec154b441ae8c3a3ec21844a) :white_check_mark: * [a86696a](https://github.com/hlxsites/danaher-ls-aem/commit/a86696a8f4f4dea76fb2b8263d86698fa9ff1aca) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/us/en/products/flow-cytometers/topics/sheath-fluid-flow-cytometry PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/products/mass-spectrometers/topics/what-is-mass-spectrometry PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
amlan18041996 commented 2 months ago

Changes applied 50% based on figma design

davenichols-DHLS commented 1 month ago

I am approving, but the CLS appears worse on this change than on current prod.

Current: https://pagespeed.web.dev/analysis/https-lifesciences-danaher-com-us-en-products-flow-cytometers-topics-sheath-fluid-flow-cytometry-html/co467ygogc?form_factor=mobile This Branch: https://pagespeed.web.dev/analysis/https-1040-header-topic-pages--danaher-ls-aem--hlxsites-hlx-page-us-en-products-flow-cytometers-topics-sheath-fluid-flow-cytometry/dpl8it3ede?form_factor=mobile

davenichols-DHLS commented 1 month ago

@amlan18041996 - are you able to please fix the conflicts and then I will merge this? Thanks.