hlxsites / danaher-ls-aem

AEM Franklin / Crosswalk site for DH Life Sciences
Apache License 2.0
2 stars 4 forks source link

1090 Compile and Build CSS for each block #1090

Closed rgravitvl closed 4 months ago

rgravitvl commented 5 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1089

Test URLs:

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [e9acddf](https://github.com/hlxsites/danaher-ls-aem/commit/e9acddf117cbf76badb875ab8a89b03541a7b6f7) :white_check_mark: (latest) * [5d02845](https://github.com/hlxsites/danaher-ls-aem/commit/5d02845ade3eb9dff656444d8c1dbca9bf07bb75) :white_check_mark: * [562486e](https://github.com/hlxsites/danaher-ls-aem/commit/562486efdc79759fe3881ec73688e62e2ceb2b56) :white_check_mark: * [7602016](https://github.com/hlxsites/danaher-ls-aem/commit/760201635b66a2240534cfc38a386beb4e992891) :white_check_mark: * [d8596dc](https://github.com/hlxsites/danaher-ls-aem/commit/d8596dc59edbe60c26f37082b4cba8fd58b18d9e) :white_check_mark: * [895e69e](https://github.com/hlxsites/danaher-ls-aem/commit/895e69e709ba42f945348dfb65ba44db815f6889) :white_check_mark: * [427dc21](https://github.com/hlxsites/danaher-ls-aem/commit/427dc211c063917228ea7bebda72e36b34744bc3) :white_check_mark: * [344deb1](https://github.com/hlxsites/danaher-ls-aem/commit/344deb117f842bc524ca188be58c24a130eed240) :white_check_mark: * [a4447ed](https://github.com/hlxsites/danaher-ls-aem/commit/a4447edf54792953cbbaf3860839ed4238f70c6c) :white_check_mark: * [33ecc7a](https://github.com/hlxsites/danaher-ls-aem/commit/33ecc7aa07fdfff4b1ae8dc0e27571cc0cd771fe) :white_check_mark: * [ecea6cc](https://github.com/hlxsites/danaher-ls-aem/commit/ecea6ccee3bdaf526f0564972d6732928a369783) :white_check_mark: * [e7376e7](https://github.com/hlxsites/danaher-ls-aem/commit/e7376e783afdeb83974d155354b7893c3ba7866d) :white_check_mark: * [42bb1b3](https://github.com/hlxsites/danaher-ls-aem/commit/42bb1b37f9a5f3a9e221e76c1b80be8c4dc1fce3) :white_check_mark: * [b5fa985](https://github.com/hlxsites/danaher-ls-aem/commit/b5fa985a419cd1c16a0f9ec5360b8a756ac933bd) :white_check_mark: * [725f19e](https://github.com/hlxsites/danaher-ls-aem/commit/725f19e2273e1e2d2407de5c12fb9d48f2e8d98d) :white_check_mark: * [44170cc](https://github.com/hlxsites/danaher-ls-aem/commit/44170cc1a66f88c56c58ccb2a040c24c48c1e9f8) :white_check_mark: * [50deaaf](https://github.com/hlxsites/danaher-ls-aem/commit/50deaaf2631a1afe5cca8cf3b293f318deb3da6e) :x: * [b2033e8](https://github.com/hlxsites/danaher-ls-aem/commit/b2033e87ca1fefbaacfb17515b1ab3bc24d704ec) :x: * [e827bd3](https://github.com/hlxsites/danaher-ls-aem/commit/e827bd3b126fbf86cccdc4cffb27af2d031797b3) :x: * [6f46c58](https://github.com/hlxsites/danaher-ls-aem/commit/6f46c58dc5890df13f0b12a02f6b3c8654373f87) :x: * [3feda27](https://github.com/hlxsites/danaher-ls-aem/commit/3feda27b84d2dcda96a0afbc3c716c0de84a7a75) :x: * [6a595e3](https://github.com/hlxsites/danaher-ls-aem/commit/6a595e36529efeeb6a361c08a6fd9a51086d3cbb) :x: * [20d77f9](https://github.com/hlxsites/danaher-ls-aem/commit/20d77f9a431fb96aabe0d6485b3cb7e124e75de2) :x: * [5c5721b](https://github.com/hlxsites/danaher-ls-aem/commit/5c5721bcb0eb74a32ec927a6e4bd29f8d7e8f912) :x: * [703ed2e](https://github.com/hlxsites/danaher-ls-aem/commit/703ed2e44985500aaa4836f8a86bcc8533109a92) :x: * [5309fb3](https://github.com/hlxsites/danaher-ls-aem/commit/5309fb31d53d1c37937ba788a4d820dcc42fd80e) :x: * [d6db5e7](https://github.com/hlxsites/danaher-ls-aem/commit/d6db5e7d8e565664e66bf8c168d50b8c080408f8) :x: * [167cae2](https://github.com/hlxsites/danaher-ls-aem/commit/167cae219fe48f47f04a1c60964c5593de853bf6) :x: * [da034c9](https://github.com/hlxsites/danaher-ls-aem/commit/da034c90c9067044c9efa79d35e13f83566264d6) :x: * [5a3ebd2](https://github.com/hlxsites/danaher-ls-aem/commit/5a3ebd2d70b3f4fa5ea407dac67bc7ee783bab91) :x:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/application/antisense-oligonucleotides PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/blog/optimizing-plasmid-production-screening PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/products PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/products/centrifuges PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/products/family/optima-auc-analytical-ultracentrifuge PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/products/flow-cytometers/topics/sheath-fluid-flow-cytometry PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/solutions/mabs/cell-line-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
davenichols-DHLS commented 5 months ago

Issues found so far:

davenichols-DHLS commented 5 months ago

Issues List

@rgravitvl -

davenichols-DHLS commented 5 months ago

Page Speed is looking great: https://pagespeed.web.dev/analysis/https-fix-css-each-block--danaher-ls-aem--hlxsites-hlx-live/t1uiff6sx4?form_factor=mobile

davenichols-DHLS commented 4 months ago

@rgravitvl - don't hate me, but some pages are giving a poor score: https://pagespeed.web.dev/analysis/https-fix-css-each-block--danaher-ls-aem--hlxsites-hlx-page-us-en-products-family-allegra-v-15r-benchtop-centrifuges/hxjp0qifea?form_factor=mobile