search

hlxsites / danaher-ls-aem

AEM Franklin / Crosswalk site for DH Life Sciences
Apache License 2.0
2 stars 4 forks source link

[UE support] 1083 ue config files #1096

Closed jckautzmann closed 2 months ago

jckautzmann commented 2 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1083

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [985cf9c](https://github.com/hlxsites/danaher-ls-aem/commit/985cf9cca5163b550f20fdd095fc225dfaa99806) :white_check_mark: (latest) * [78dd7dd](https://github.com/hlxsites/danaher-ls-aem/commit/78dd7dd131a1ca0df8cf93a71b87b38bfdea6c8a) :white_check_mark: * [a645af7](https://github.com/hlxsites/danaher-ls-aem/commit/a645af7613129bd62c0c89fcd43c62399dae4bc3) :white_check_mark: * [0451546](https://github.com/hlxsites/danaher-ls-aem/commit/0451546854ee9e5eb63799db7a9d5e748ff2f291) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
mhaack commented 2 months ago

I think we need more components defined, check a typical topic page https://stage.lifesciences.danaher.com/us/en/products/centrifuges/topics/cell-harvesting-centrifugation-techniques.md we need takeaway, accordion...

jckautzmann commented 2 months ago

@mhaack Agreed. This is a first step, so that I can verify on a test page that the breadcrumb component supports the UE. The configuration for all the other blocks will follow after.