hlxsites / danaher-ls-aem

AEM Franklin / Crosswalk site for DH Life Sciences
Apache License 2.0
2 stars 4 forks source link

1133 [ReBrand] About Us and DBS Page redesign and implement in Crosswalk #1143

Closed sharanagoudapatil closed 4 months ago

sharanagoudapatil commented 4 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1133

Test URLs:

aem-code-sync[bot] commented 4 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [0d714c3](https://github.com/hlxsites/danaher-ls-aem/commit/0d714c3900facfda782ed5e319876edb5812bb70) :white_check_mark: (latest) * [28dc02c](https://github.com/hlxsites/danaher-ls-aem/commit/28dc02cbb78633e7d1222ec386864d28b0a2c7c7) :white_check_mark: * [6ca442e](https://github.com/hlxsites/danaher-ls-aem/commit/6ca442e07d40bc8c6f53b0e9b047e794f67a36a7) :white_check_mark: * [17aaf82](https://github.com/hlxsites/danaher-ls-aem/commit/17aaf8222bfc7d612745b5e290a8cbfdc619b03f) :white_check_mark:
aem-code-sync[bot] commented 4 months ago
Page Scores Audits Google
/us/en/about-us PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/us/en/about-us/danaher-business-system PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
davenichols-DHLS commented 4 months ago

@sharanagoudapatil - on the About Us, the page speed is poor because of the video. Is there a way that we can load the Vimeo videos (dont worry about youtube) delayed?

For example: https://pagespeed.web.dev/analysis/https-1133-about-us-rebrand--danaher-ls-aem--hlxsites-hlx-page-us-en-about-us1/bvqk3ay10a?form_factor=mobile

FYI @rgravitvl

sharanagoudapatil commented 4 months ago

Hi @davenichols-DHLS/ @rgravitvl - Yes, I agree the page speed is poor for the video script. I've added the delay for 5 seconds in the embed.js. Please verify.
setTimeout(() => {
loadEmbed(block, link); }, 5000);