hlxsites / danaher-ls-aem

AEM Franklin / Crosswalk site for DH Life Sciences
Apache License 2.0
2 stars 4 forks source link

1154 [SEO] Converter update Embed Placeholder #1195

Closed sharanagoudapatil closed 2 months ago

sharanagoudapatil commented 3 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1154

Test URLs:

aem-code-sync[bot] commented 3 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [156b7db](https://github.com/hlxsites/danaher-ls-aem/commit/156b7db827ff88ee511b9eab0f647b41bcd6fe4e) :white_check_mark: (latest) * [088440a](https://github.com/hlxsites/danaher-ls-aem/commit/088440a1de1bf3cda80613e0f18f45b331dea879) :white_check_mark: * [5cb6a2f](https://github.com/hlxsites/danaher-ls-aem/commit/5cb6a2f08cc7b2b896ca408265afe91c17b55b17) :white_check_mark: * [9e23319](https://github.com/hlxsites/danaher-ls-aem/commit/9e23319972ad2e16e8764f44bec6fca55199254d) :white_check_mark:
aem-code-sync[bot] commented 3 months ago
Page Scores Audits Google
/us/en/about-us/about-us-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
rgravitvl commented 2 months ago

@sharanagoudapatil LGTM. But before merge please fix the converter test cases and proceed. Thanks.

@rgravitvl - I've updated the test cases. Thanks.