hlxsites / delta

https://main--delta--hlxsites.hlx.page/us/en/skymiles/overview
Apache License 2.0
2 stars 3 forks source link

feat: WCAG compliant footer search #129

Closed ramboz closed 1 year ago

ramboz commented 1 year ago

Inline search suggestion is tackled separately in #131.

Fix #110

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
askayastha22 commented 1 year ago

@ramboz Info text above the search bar is missing when the element is in focus.

Screenshot 2023-04-04 at 7 24 50 PM Screenshot 2023-04-04 at 7 24 40 PM
askayastha22 commented 1 year ago

@ramboz Below breakpoint 768px, the placeholder search text is too large.

Screenshot 2023-04-04 at 7 32 33 PM Screenshot 2023-04-04 at 7 32 48 PM
askayastha22 commented 1 year ago

@ramboz Nitpicking 🙂. The search bar has different style below breakpoint 768px.

Screenshot 2023-04-04 at 7 37 18 PM Screenshot 2023-04-04 at 7 37 41 PM
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
ramboz commented 1 year ago

@askayastha22

Info text above the search bar is missing when the element is in focus

This is similar to the behavior they had. It's just that the placeholder will move "up" once you start typing. Focusing alone won't do it. Thought it was a "minor" sacrifice for simplifying the code (as I can just check for the ::placeholder-visible pseudo selector instead of hacking this via JS)

The search bar has different style

Same reason :-p avoids a lot of CSS clutter and actually makes it properly accessible, otherwise the field is too small.

The initial footer JS is so "broken" as it is, I'm not even sure I'd want to mimic it's current behavior, and I don't think regular users would really complain about the changed experience. Let's see what feedback the UX review provides.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI