hlxsites / delta

https://main--delta--hlxsites.hlx.page/us/en/skymiles/overview
Apache License 2.0
2 stars 3 forks source link

Style for CTA section #48

Closed asthabh23 closed 1 year ago

asthabh23 commented 1 year ago

Fix #41

Test URLs:

Note: This PR also has a fix for buttons "DISCOVER ALL CARDS" and "Benefits Terms"

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
ramboz commented 1 year ago

It seems my work on the references have leaked into that button as I see a small tag being added. I'll have a look today and try to fix that.

I added also support for CTA buttons by making them bold in the document. So we essentially have 3 button variants:

There is also an existing "eyebrow" decoration that @davidnuescheler set up on that particular section. So you can leverage that class to simplify your selectors.

All in all, with the combination of cta button styles and the eyebrow class, we should be able to bring this down to mostly just padding/margin adjustments, I think

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
asthabh23 commented 1 year ago

@ramboz , I saw the main branch for this site, and seems the buttons are already in place based on your changes. Shall I close this PR?

ramboz commented 1 year ago

@asthabh23 I styled the buttons alone, but haven't looked at the spacing/margin for the cta section (that david decorated with the eyebrow class already). There might be some adjustments needed.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI
ramboz commented 1 year ago

@asthabh23 I took the liberty to update this PR during your sick leave with the changes I had already committed for the buttons, and also fixed the eyebrow decoration from David. Happy to discuss and revisit this once you are back