search

hlxsites / delta

https://main--delta--hlxsites.hlx.page/us/en/skymiles/overview
Apache License 2.0
2 stars 3 forks source link

Accordion Block #89

Closed asthabh23 closed 1 year ago

asthabh23 commented 1 year ago

Fix #60

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners Lighthouse returned error: Something went wrong. PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
askayastha22 commented 1 year ago

@asthabh23 🐛 Bug Alert

https://user-images.githubusercontent.com/108121450/224128905-34d2536d-af07-4ae2-8c39-204868558b18.mov

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/drafts/asthabharga/us/en/skymiles/how-to-earn-miles/airline-partners SI FCP LCP TBT CLS PSI
asthabh23 commented 1 year ago

@ramboz @askayastha22 Thanks for the feedbacks I have incorporated them in my latest commit, fixed the bug and also added styling for the optional text. Please have a look and merge into main if all fine :)

ramboz commented 1 year ago

@askayastha22 Care to re-review now that @asthabh23 has addressed the remaining points?

askayastha22 commented 1 year ago

@ramboz Yeah, I tested the new changes. Looks good. 👍