hlxsites / elixirsolutions

Apache License 2.0
0 stars 1 forks source link

Removed Bubbles from site banners and vertically aligned images that … #216

Closed seanmilfort closed 12 months ago

seanmilfort commented 1 year ago

…were surrounded by bubbles. Removed the word Test that was previously typed on README to check if Sean Milfort had access to write to repo.

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #184

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/aboutus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/plansponsors PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 12 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sforschen commented 12 months ago

columns.css

@seanmilfort some additional changes

image change 50px to var(--default-content-gap)

Marketing requested the remaining images to be bigger so we need to change the minimum of 280px to 352px and 320px to 352px image

image

I will need to go in and upload new pictures that are bigger than 280px

In this page https://184-remove-bubbles--elixirsolutions--hlxsites.hlx.live/aboutus

I updated the careers section image to be bigger so you can see the effects when the code it changed

aem-code-sync[bot] commented 12 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI