hlxsites / fonterra-fernleaf

Apache License 2.0
1 stars 2 forks source link

Code Cleanup #226

Closed noormd08 closed 1 year ago

noormd08 commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #200

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/en PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/en PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 1 year ago

@noormd08 best practices score is reduced, please see https://pagespeed.web.dev/analysis/https-200-search-query--fonterra-fernleaf--hlxsites-hlx-live-en/fay5hwtd7t?form_factor=mobile

asthabh23 commented 1 year ago

@sselvara , please have a look at my comment above before merging

sselvara commented 1 year ago

@asthabh23 please check https://pagespeed.web.dev/analysis/https-200-search-query--fonterra-fernleaf--hlxsites-hlx-live-en/6e7uvkh506?form_factor=mobile


https://pagespeed.web.dev/analysis/https-200-search-query--fonterra-fernleaf--hlxsites-hlx-live-en/fay5hwtd7t?form_factor=desktop

I have tested twice before approving it, error log issue under best practices is not from our scripts as per the report, it is in gtm-monitor scripts or in core-js library.

image image
sselvara commented 1 year ago

@asthabh23 Best practices score is 100 for me most of the time, please check https://pagespeed.web.dev/analysis/https-200-search-query--fonterra-fernleaf--hlxsites-hlx-live-en/cmlnmgzx5l?form_factor=mobile