search

hlxsites / franklin-assets-selector

Use this repository template for new Helix Pages projects.
Apache License 2.0
6 stars 5 forks source link

Add asset selector to core Franklin configuration #34

Open mfrisbey opened 1 year ago

mfrisbey commented 1 year ago

The asset selector should be part of Franklin's core setup, meaning there shouldn't be special configuration required on the customer's end. We need to figure out what this looks like.

An initial thought is that the setup should only consist of adding the plugin (with very simple configurations) to a customer repository.

tmathern commented 1 year ago

An initial thought is that the setup should only consist of adding the plugin (with very simple configurations) to a customer repository. <= this will be made possible once we have a static URL hosted somewhere we'll be able to point to.

sdmcraft commented 1 year ago

I think for phase-1 , we can add documentation on this in the Franklin Site which list the steps to get this working. I have edit access on the Franklin site so can take a stab at it. @tmathern feel free to reassign this to me.

tmathern commented 1 year ago

Sounds good!

sdmcraft commented 1 year ago

Shared draft public doc for review https://main--helix-website--adobe.hlx.page/drafts/satyam/aem-assets-sidekick-extension

mfrisbey commented 1 year ago

Thinking out loud here, but what would your thoughts be on adding a new button to the sidekick:

asset-button

(that's obviously just a mockup)

We could potentially control whether the button appears with a flag setting in the sidekick config (or maybe as a project setting in the UI):

{
  ...
  showAssets: true,
  ...
}

This might be more work, but IMO it has the following advantages:

What are your thoughts @sdmcraft @tmathern @badvision?

sdmcraft commented 12 months ago

would your thoughts be on adding a new button to the sidekick:

My thoughts are aligned on making this natively available in sidekick. This was the original requirement in this ticket as well. This likely would require a sidekick enhancement that I logged here https://github.com/adobe/helix-sidekick-extension/issues/517 . I see the documentation approach as an interim option for phase-1 till we get the sidekick enhanced.