search

hlxsites / hsf-commonmoves

Apache License 2.0
0 stars 2 forks source link

Floating image design 1 #261

Closed jindaliiita closed 1 month ago

jindaliiita commented 1 month ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [f2862eb](https://github.com/hlxsites/hsf-commonmoves/commit/f2862ebdd1728fceb46542a76a63bf98a8c5ada1) :white_check_mark: (latest) * [e0645eb](https://github.com/hlxsites/hsf-commonmoves/commit/e0645eb92c147f5def6ddc1226dfe7b28d587fa1) :white_check_mark: * [ef1d4fd](https://github.com/hlxsites/hsf-commonmoves/commit/ef1d4fd6e36c4ed76a206d43ee1b1b1ee3a0536c) :white_check_mark: * [31498e0](https://github.com/hlxsites/hsf-commonmoves/commit/31498e0842cb004fd929a261f69349d88b71303f) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/drafts/piyush/floating-image PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
jindaliiita commented 1 month ago

I don't think its necessary to separate out the CSS for the Agent template design - or if you do, just import it in the root floating-images.css; dynamically loading it isn't necessary

We maintained separate files to ensure readability. Additionally, there will be multiple designs, but only one will load at a time, ultimately saving bytes over the network.