search

hlxsites / macquarie-help-centre

Apache License 2.0
1 stars 2 forks source link

Implementation of Search Functionality #109

Closed vaibhav2601 closed 1 year ago

vaibhav2601 commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #41

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
vaibhav2601 commented 1 year ago

Currently the pagination logic seems to be incorrect, on clicking next page we are reloading the entire page, but in the actual website, the url remains same and the pagination happens at client side without reloading page again, hence quicker.

We should filter data once and on clicking next/or specific page just show required set of data.

Had discussion with @asthabh23 on the same. We are adding the query param in the URL for each page and reloading the data based on query param

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
ujjwal5 commented 1 year ago

Currently the pagination logic seems to be incorrect, on clicking next page we are reloading the entire page, but in the actual website, the url remains same and the pagination happens at client side without reloading page again, hence quicker. We should filter data once and on clicking next/or specific page just show required set of data.

Had discussion with @asthabh23 on the same. We are adding the query param in the URL for each page and reloading the data based on query param

@asthabh23 if we are okay reloading the page everytime user clicks on a different page number, then I'm good.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/search-results PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 1 year ago

@asthabh23 if we are okay reloading the page everytime user clicks on a different page number, then I'm good.

yes, we will proceed with this pagination approach