hlxsites / macquarie-help-centre

Apache License 2.0
1 stars 2 forks source link

12 accordion block #59

Closed ujjwal5 closed 1 year ago

ujjwal5 commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #12

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/personal/home-loans PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/personal/home-loans/apply-for-a-home-loan PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
rhudea commented 1 year ago

There seems to not any transition while the accordion is opening/closing. The fonts on desktop look bolder. The font size breakpoint do not match: 1280 on original site, 900 on this. - should be at 1200.

ujjwal5 commented 1 year ago

There seems to not any transition while the accordion is opening/closing. The fonts on desktop look bolder. The font size breakpoint do not match: 1280 on original site, 900 on this. - should be at 1200.

Thanks for reviewing, will have a look at these.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/personal/home-loans PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/personal/home-loans/apply-for-a-home-loan PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
ujjwal5 commented 1 year ago

There seems to not any transition while the accordion is opening/closing. The fonts on desktop look bolder. The font size breakpoint do not match: 1280 on original site, 900 on this. - should be at 1200.

Will fix transition as part of another issue together with header animation. Fixed remaining issues. Closing this PR and created another PR for accordion: https://github.com/hlxsites/macquarie-help-centre/pull/71