Closed rhudea closed 1 year ago
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-interest |
The video-wrapper
should match the width of default-content-wrapper
(width: calc(100% * 2/3);
). Right now it expands to 100% in desktop mode.
Not sure how best we can achieve it, especially that this will change with the "long article" styling...
🐛 Clicking outside of the modal restarts the video instead of closing it.
🐛 click on the X to close the video triggers a js error in the console:
Uncaught TypeError: player?.stopVideo is not a function
at toggleVideoOverlay (video.js:82:15)
at HTMLDivElement.<anonymous> (video.js:197:45)
The "Watch now" button should be aligned with the bottom-left corner in mobile mode, i.e.:
Currently there's some padding (from the desktop view):
Page | Scores | Audits | |
---|---|---|---|
/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-interest |
The
video-wrapper
should match the width ofdefault-content-wrapper
(width: calc(100% * 2/3);
). Right now it expands to 100% in desktop mode.Not sure how best we can achieve it, especially that this will change with the "long article" styling...
I agree on this, the width of the video wrapper needs to match the width of default content (for now, its full width almost)
Page | Scores | Audits | |
---|---|---|---|
/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-interest |
Page | Scores | Audits | |
---|---|---|---|
/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-interest | Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) |
Page | Scores | Audits | |
---|---|---|---|
/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-interest | Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) |
Page | Scores | Audits | |
---|---|---|---|
/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-interest | Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) |
Page | Scores | Audits | |
---|---|---|---|
/help/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-int erest |
Page | Scores | Audits | |
---|---|---|---|
/help/personal/home-loans/manage-repayments-and-interest-rate/your-home-loan-int erest |
@rhudea , customer confirmed that they just need inline support for videos. you could update the same in this PR itself
Close in favor #84
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #27
Test URLs: