hlxsites / macquarie-help-centre

Apache License 2.0
1 stars 2 forks source link

Adding accordion block implementation #71

Closed ujjwal5 closed 1 year ago

ujjwal5 commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #12

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/personal/home-loans Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/personal/home-loans/apply-for-a-home-loan Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/home-loans PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/help/personal/home-loans/apply-for-a-home-loan PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/home-loans PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/help/personal/home-loans/apply-for-a-home-loan PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 1 year ago

looks good to me though.. for animation I have added separate GH issue

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/personal/home-loans PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/help/personal/home-loans/apply-for-a-home-loan PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI