hlxsites / macquarie-help-centre

Apache License 2.0
1 stars 2 forks source link

12 accordion variation #82

Closed ujjwal5 closed 1 year ago

ujjwal5 commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #12

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/drafts/ujjgupta/helping-you-transact-online PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/drafts/ujjgupta/helping-you-transact-online PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/help/drafts/ujjgupta/helping-you-transact-online PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
ujjwal5 commented 1 year ago

animation for carousel is still pending, I suppose that would be covered as part of seperate PR, rest looks good.

@asthabh23 you meant accordion right? :)

asthabh23 commented 1 year ago

@asthabh23 you meant accordion right? :) definitely yes @ujjwal5 :)