hlxsites / mammotome

Franklin site for https://www.mammotome.com/
https://www.mammotome.com/
Apache License 2.0
1 stars 5 forks source link

575 fix: Update prev-next.js using HTML instead of Text #576

Closed davenichols-DHLS closed 6 months ago

davenichols-DHLS commented 7 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #575

Test URLs:

aem-code-sync[bot] commented 7 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [109cf6c](https://github.com/hlxsites/mammotome/commit/109cf6c4c126000c8f474ea82a189dfb85fdff69) :white_check_mark: (latest)
aem-code-sync[bot] commented 7 months ago
Page Scores Audits Google
/us/en/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
davenichols-DHLS commented 7 months ago

we specifically used innerText so as to prevent HTML evaluation of content for security reasons. also, the SEO score has dropped.

Thank you for checking @solaris007 - but they are adding Trademark references and icons/HTML in Word on the titles which are then not showing correctly. For example, if you add a Trademark icon in the title then it either doesn't show or shows like this. Can you think of an alternative, as I think that they want this.

image

davenichols-DHLS commented 6 months ago

i checked again and see no alternative right now. please proceed :)

Thank you - sorry, I did also try to think of alternatives but couldn't think of a way around this.