QA: /company

[helms-charity]

Company page Design QA v1.docx

@sachinmesh I made a new issue for your Company page Word doc. We can continue the review conversation via these issues and then close them when the page is accepted.

https://main--merative2--hlxsites.hlx.page/company

[arumsey]

@sachinmesh https://main--merative2--hlxsites.hlx.page/company is ready for another review.

[keith-kaplan]

@arumsey can we evaluate how the teaser component? It looks like it's pulling in info based on URL. That's a nice feature, but we'd like to be able to author this component with a title, description, CTA. As you can see the page titles often times have "| Merative". What other options do we have for this?

[sachinmesh]

Sharing the observations only on desktop and updated the previous sheet here as attachment. Company page Design QA v2.pdf CC: @anabarcelona

[anabarcelona]

Thanks Sachin! Looking good!!

[arumsey]

@sachinmesh Could you elaborate on what is wrong with the CTA design? Also, is the CTA button design different from the Primary button design or should they be identical?

I did notice that the space after the icon should be 16px and not 24px so I made that change. Are there still additional fixes that need to be applied to ALL CTA/Primary buttons?

[arumsey]

@sachinmesh Should the left content of the Leadspace block always be vetically centered?

Like this?

[helms-charity]

@sachinmesh On this leadspace in Tablet -- I measured all the comps, and in tablet, the left text was usually 64px from bottom. The top margin was fluid.

[arumsey]

@arumsey can we evaluate how the teaser component? It looks like it's pulling in info based on URL. That's a nice feature, but we'd like to be able to author this component with a title, description, CTA. As you can see the page titles often times have "| Merative". What other options do we have for this?

@keith-kaplan You would like the teser-list to allow for both automatic title/description/CTA as well as being fully authorable too?

[keith-kaplan]

If we can do that, that would be nice. If we had to prioritize I'd say I'd rather it authorable because it's automatically pulling in page title, descriptions, and automating the CTA the content it pulls in may not be what we want it to be.

[sachinmesh]

@sachinmesh Could you elaborate on what is wrong with the CTA design? Also, is the CTA button design different from the Primary button design or should they be identical?

I did notice that the space after the icon should be 16px and not 24px so I made that change. Are there still additional fixes that need to be applied to ALL CTA/Primary buttons?

This is correct. All CTAs with an icon should have these specifications on all pages.

[arumsey]

If we can do that, that would be nice. If we had to prioritize I'd say I'd rather it authorable because it's automatically pulling in page title, descriptions, and automating the CTA the content it pulls in may not be what we want it to be.

I just confirmed that teaser list is already authorable. The title, description and link title can all be customized by the author.

[arumsey]

@sachinmesh I think the only remaining issue is regarding Leadspace layout.

https://github.com/hlxsites/merative/issues/173#issuecomment-1506958241

[sachinmesh]

@sachinmesh On this leadspace in Tablet -- I measured all the comps, and in tablet, the left text was usually 64px from bottom. The top margin was fluid.

The right image is always bottom aligned in tablet even if the length in text side increases. CC: @anabarcelona

[helms-charity]

@sachinmesh I am not seeing the right image leaving the bottom in any breakpoint. I was addressing your point 21 in the PDF:

[sachinmesh]

@sachinmesh I am not seeing the right image leaving the bottom in any breakpoint. I was addressing your point 21 in the PDF:

Here i guess at this breakpoint extra spacing on both ends.

[helms-charity]

@sachinmesh thank you, but I'm still a bit confused. Can you be more specific on your comment of "Here i guess at this breakpoint extra spacing on both ends."?

Are you saying YES to Anthony's question "Should the left content of the Leadspace block always be vetically centered?" at https://github.com/hlxsites/merative/issues/173#issuecomment-1506928763 ?

And if so, is this your direction for ALL leadspace left content at the Tablet size?

[sachinmesh]

@sachinmesh thank you, but I'm still a bit confused. Can you be more specific on your comment of "Here i guess at this breakpoint extra spacing on both ends."?

Are you saying YES to Anthony's question "Should the left content of the Leadspace block always be vetically centered?" at #173 (comment) ?

And if so, is this your direction for ALL leadspace left content at the Tablet size?

Here you can see the layout from top merative logo and meet merative alignment.

[arumsey]

@sachinmesh thank you, but I'm still a bit confused. Can you be more specific on your comment of "Here i guess at this breakpoint extra spacing on both ends."? Are you saying YES to Anthony's question "Should the left content of the Leadspace block always be vetically centered?" at #173 (comment) ? And if so, is this your direction for ALL leadspace left content at the Tablet size?

Here you can see the layout from top merative logo and meet merative alignment.

@sachinmesh What are you expecting to see between the top Merative logo and the Meet Merative text?

In this screenshot the Leadspace block is at its maximum width and is cenered aligned on the page. The extra space above the "Meet Merative" text is due to the height of the Leadspace image which is determined by its width in order to maintain the correct aspect ratio.

[sachinmesh]

From 1199px till 768px resolution, there's this padding. the top navigation bar and the layout below it is not aligned, thats what i was pointing out.

CC: @keith-kaplan @anabarcelona

[helms-charity]

Thanks so much, @sachinmesh for that detail. I just checked, and this is not a defect. The tablet content is fixed at the width that was in your Figma designs for every page. However, the header (and footer) is allowed to be fluid.