QA: /events/2023-zelta-user-conference

helms-charity commented 1 year ago

This is the 'new' event page layout.

arumsey commented 1 year ago

@sachinmesh ready for review

keith-kaplan commented 1 year ago

Helping out with QA'ing this page until @sachinmesh can jump in... This font size needs to be 21px

Spacing between these blocks should be 96px

Accordion block is not supposed to span full width. It's suppose to have 284px on right padding. It also looks like the padding on top and bottom make the height of each accordion item too tall.

sachinmesh commented 1 year ago

Adding my observations with attached PDF

Zelta Event page QA v1 (1).pdf

CC: @keith-kaplan @anabarcelona

keith-kaplan commented 1 year ago

Clarification on this one. For the event leadspace, we want to make sure the html tag is still an H1 tag vs an H2 tag. I think Sachin mentioned the style/typography on the heading and not the tag.

arumsey commented 1 year ago

Most of your issues have been addressed here: https://182-events-qa--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference (@keith-kaplan @sachinmesh).

One outstanding issue is the spacing between Marketo form labels and fields. There is some custom CSS being delivered with the Marketo form that forces the label padding to be 12px. This custom CSS provided by Marketo has a higher importance that the Franklin CSS which is why we cannot change it to 16px. You should be able to add extra px from the Marketo side potentially.

arumsey commented 1 year ago

@sachinmesh & @keith-kaplan The events pages are ready for review again.

sachinmesh commented 1 year ago

Hi Team, Sharing the review here in PDF. Also, issues which are pending are mentioned below.

Zelta Event page QA v2.pdf

Leadspace Heading font style should be H2 – Source serif pro 45px light, for event leadspace only. - Not Fixed

Content band list The spacing between title and 3 icons list should be 48px. - Not Fixed

Simple content component Title and body text should be 32px. - Not Fixed Padding above and below should be 160px. - Not Fixed

Form component Submit CTA should have 48px spacing above. - Not Fixed

CC: @keith-kaplan @anabarcelona

arumsey commented 1 year ago

Leadspace Heading font style should be H2 – Source serif pro 45px light, for event leadspace only. - Not Fixed

@sachinmesh I am seeing Source Serif Pro Light and 45px. What are you getting?

arumsey commented 1 year ago

Content band list The spacing between title and 3 icons list should be 48px. - Not Fixed

@sachinmesh I am seeing 32px + 16px = 48px spacing between title and three icons. What are you getting?

arumsey commented 1 year ago

Simple content component

Title and body text should be 32px. FIXED

Padding above and below should be 160px. - Not Fixed

@sachinmesh Where are you expecting to see the 160px padding? Currently there is 160px padding at the top and bottom of the sectino that contains all the simple content blocks.

arumsey commented 1 year ago

Form component Submit CTA should have 48px spacing above. FIXED

I had to fight with styles coming form Marketo but all the extra margins should be removed now resulting in an actual 48px gap between form content and Submit button.

sachinmesh commented 1 year ago

Hi, This is the link i was checking https://main--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference

This link is showing 404 error https://182-events-qa--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference

CC: @keith-kaplan @anabarcelona

arumsey commented 1 year ago

Hi, This is the link i was checking https://main--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference

This link is showing 404 error https://182-events-qa--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference

CC: @keith-kaplan @anabarcelona

https://182-events-qa--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference has been merged.

Can you please elaborate on the following oustanding questions using https://main--merative2--hlxsites.hlx.page/events/2023-zelta-user-conference.

Heading font style should be H2 – Source serif pro 45px light, for event leadspace only. (Leadspace heading font size is already 45px)
The spacing between title and 3 icons list should be 48px (Margin between title and content-band icons is already 48px)
Padding above and below should be 160px (Padding above and below the simple content section is already 160px)

If you are still encountering these issues please provide screenshots on what you are seeing in your browser.

@sachinmesh

sachinmesh commented 1 year ago

Hi,

Here the title Zelta User conference is showing H1 is fixed now.

Here the padding shows 32px, it should be 48px.

The spacing between each quarter circle components should have 160px above and below. like this in design

CC: @keith-kaplan @anabarcelona

keith-kaplan commented 1 year ago

@sachinmesh It should be 96px between the "learn" blocks. not 160px.

@arumsey I'm seeing 96px so it should be good.

arumsey commented 1 year ago

Here the padding shows 32px, it should be 48px.

@sachinmesh Please refer to https://github.com/hlxsites/merative/issues/182#issuecomment-1527542124

There is an additional 16px margin above the icons resulting in a total of 48px.

sachinmesh commented 1 year ago

Looks good. Thank you.

hlxsites / merative

QA: /events/2023-zelta-user-conference #182