hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

chore(csp): Update CSP to allow *.hotjar.io wss://*.hotjar.com #240

Closed proeung closed 1 year ago

proeung commented 1 year ago

Issue

Fixes -

Description

Changed

Design Specs

Test URLs

Testing Instruction

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@keith-kaplan Thanks for pointing that out. Please see the new commit here - https://github.com/hlxsites/merative2/pull/240/commits/7369543e4edcafa5db2e56c7a15b88aad430fc27

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ Lighthouse returned error: Something went wrong. PSI
keith-kaplan commented 1 year ago

looks good. I think the lighthouse check failed.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@keith-kaplan Just re-run the psi-check CI.

Also, I noticed that @amol-anand added this performance issue for improving CSP, which is adding to the size of the pages.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@amol-anand @helms-charity Perhaps this is a known issue, but I keep getting inconsistent page performance scores from the helix-psi-check, despite not pushing any new code. Do you know why that is?

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI