hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(blog-detail): add correct spacing to paragraph #243

Closed proeung closed 1 year ago

proeung commented 1 year ago

Issue

Fixes https://github.com/hlxsites/merative2/issues/246

Description

Changed

Design Specs

Test URLs

Screen Shot 2023-06-20 at 3 02 36 PM

Screen Shot 2023-06-20 at 4 37 58 PM

Testing Instruction

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@keith-kaplan Great find! We have the styling for the <ol> unordered list defined in the Design System Figma file (see - link), however, these styles were not accounted for in the code because it wasn't a treatment that was being displayed as options within the Blog detail page design (see link).

Anywho, I went in and added the styling for the <ol> and <ul> to reflect the design system. @sachinmesh or @anabarcelona Can you take a look at this page (https://fix-blog-paragraph-spacing--merative2--proeung.hlx.page/blog/ism-recap-2022) and let me know if the styles for the listing and paragraph are correct for all breakpoints? Thanks!

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

Adding @sachinmesh's design QA feedback that he left in the JIRA comment (https://jira.wh-sdlc.watson-health.ibm.com/browse/MERATIVE-768).

HI Putra Bonaccorsi

The spacing between paragraphs around 48px is good.

Can we increase the spacing between the title and curam image to 48px. As well above the Marcy Tatsch image to 48px.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@sachinmesh This PR is ready for a design QA re-review.

Screen Shot 2023-06-22 at 11 37 09 AM Screen Shot 2023-06-22 at 11 36 56 AM

sachinmesh commented 1 year ago

HI @proeung This spacing between title and curam image should be 48px in desktop and 32px in tablet / Mobile.

image
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@sachinmesh Okay, can you check again?

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 1 year ago

HI @proeung , thank you for the spacing adjustment. Now its good. One last thing i saw was the font style of selected text in table of contents. It should be H5, i.e 16px Alliance No.1 Regular and not semibold.

image
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/ism-recap-2022 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

HI @proeung , thank you for the spacing adjustment. Now its good. One last thing i saw was the font style of selected text in table of contents. It should be H5, i.e 16px Alliance No.1 Regular and not semibold.

@sachinmesh I already fixed this in another PR, but for some reason, this deploy preview is still loading the cached version. I've raised this caching issue with folks from the Adobe side (https://adobe-dx-support.slack.com/archives/C04BLPWJRGR/p1687803179395579). Regardless, this font family as already been addressed (see this deploy preview - https://fix-blog-paragraph-spacing-2--merative2--proeung.hlx.page/blog/marcy-tatsch-curam).

Also, let's keep the scope of this PR to just the description outlined above.