Closed nimithshetty17 closed 1 year ago
aem-code-sync[bot]
commented
1 year ago Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |     |
     |
 |
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |  |
     |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |  |
   |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast | |
   |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |  |
    |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |  |
    |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |  |
   |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast |  |
   |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/nimith/podcast | |
  |
|
nimithshetty17
commented
1 year ago @proeung - Thanks for the comments! Have made the changes for the CSP and the podcast is available now for review.
sachinmesh
commented
1 year ago Hi @nimithshetty17 @proeung checked the functionality in all breakpoints, working fine. We don't have designs specially created for podcast in design system. We can add the podcast iframe below the speakers title and name above the bodycopy of the podcasts description.
Issue:- Fixes https://jira.wh-sdlc.watson-health.ibm.com/browse/MERATIVE-742
Description:-
This PR is for creating a new block to embed the apple and spotify podcast.
Design Specs Figma Link - https://www.figma.com/file/dFJwrp6VkUMSirF2KMLRMx/Thought-leadership-library?type=design&node-id=357-17001&mode=design&t=NJAN5HiO1NaRacYg-0
Test URLs
After (Changes from this PR): https://podcast-iframe-block--merative2--nimithshetty17.hlx.page/drafts/nimith/podcast Testing Instruction Visit one of the documents(eg. https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/doc2.aspx?sourcedoc=%7B6A71CB0E-7486-47E2-82E0-47850F2159B1%7D&file=podcast.docx&action=default&mobileredirect=true) Add the block by adding the url and the spotify or apple link.