hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(merative-history): add static build artifacts #251

Closed proeung closed 1 year ago

proeung commented 1 year ago

Issue

Fixes https://jira.wh-sdlc.watson-health.ibm.com/browse/MERATIVE-726

Description

Changed

Note

Design Specs

Test URLs

Screen Shot 2023-06-22 at 4 33 49 PM

Testing Instruction

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@keith-kaplan @nimithshetty17 I decided to host these static build artifacts in the /resources/history of this repo and it seems to work. Can you take a look at the DOM elements of the index.html and let me know if there are other tags that are missing? I added the Adobe Tag Manager, but I'm sure there is other metadata that's needed.

proeung commented 1 year ago

Note: Also, LHS might be low because these images are in .png. I can convert them into .webp, if we feel good about what's in this PR.

helms-charity commented 1 year ago

I see a problem with putting this under /resources, because that is going to AEMaaCS I believe. You should put it in a different folder.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@keith-kaplan The One Trust script has been added (see - https://github.com/hlxsites/merative2/pull/251/commits/6f7ca7f1f1aa3f1770f421a623279256c9507984).

I see a problem with putting this under /resources, because that is going to AEMaaCS I believe. You should put it in a different folder.

@helms-charity That shouldn't be an issue as we're going to remove the /resource from AEMaaCS.

@nimithshetty17 Can you remove any references of /resources or /resources/history on our AEM's environments? Next step is to change the CDN routing of /resources back to Franklin.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

Marking this PR as "On-Hold" until we know which copy to use for the rebranding SPM to Cúram (see - https://merative.monday.com/boards/3096780490/views/92911261).

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

Added copy changes based on the changes outlined in this Monday.com card (https://merative.monday.com/boards/3096780490/views/92911261/pulses/4537485904/posts/2239610770).

@venky-moonraft @keith-kaplan Can you take a look?

Screen Shot 2023-06-26 at 2 31 34 PM

https://feat-add-merative-history--merative2--proeung.hlx.page/resources/history/index.html

keith-kaplan commented 1 year ago

@proeung may we please move the Tag manager script below the Onetrust script? The Onetrust script needs to load first so if visitors choose to not accept cookies, some of the tag manager scripts won't load.

image
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@proeung may we please move the Tag Manager script below the Onetrust script? The Onetrust script needs to load first so if visitors choose to not accept cookies, some of the tag manager scripts won't load.

@keith-kaplan That's good to know. I was just following the script load order that we had on the AEM dev environment (view-source:https://dev.merative.com/resources/history).

Changes are up, can you take a look again? https://github.com/hlxsites/merative2/pull/251/commits/5bfebccb860e15869f2346e3490409239af85c00

keith-kaplan commented 1 year ago

Looks great. Thank you.

venky-moonraft commented 1 year ago

Looks good @proeung

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/resources/history/index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI