Closed proeung closed 1 year ago
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
@keith-kaplan @nimithshetty17 I decided to host these static build artifacts in the /resources/history
of this repo and it seems to work. Can you take a look at the DOM elements of the index.html
and let me know if there are other tags that are missing? I added the Adobe Tag Manager, but I'm sure there is other metadata that's needed.
Note: Also, LHS might be low because these images are in .png
. I can convert them into .webp
, if we feel good about what's in this PR.
I see a problem with putting this under /resources, because that is going to AEMaaCS I believe. You should put it in a different folder.
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
@keith-kaplan The One Trust script has been added (see - https://github.com/hlxsites/merative2/pull/251/commits/6f7ca7f1f1aa3f1770f421a623279256c9507984).
I see a problem with putting this under /resources, because that is going to AEMaaCS I believe. You should put it in a different folder.
@helms-charity That shouldn't be an issue as we're going to remove the /resource
from AEMaaCS.
@nimithshetty17 Can you remove any references of /resources
or /resources/history
on our AEM's environments? Next step is to change the CDN routing of /resources
back to Franklin.
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Marking this PR as "On-Hold" until we know which copy to use for the rebranding SPM to Cúram (see - https://merative.monday.com/boards/3096780490/views/92911261).
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Added copy changes based on the changes outlined in this Monday.com card (https://merative.monday.com/boards/3096780490/views/92911261/pulses/4537485904/posts/2239610770).
@venky-moonraft @keith-kaplan Can you take a look?
https://feat-add-merative-history--merative2--proeung.hlx.page/resources/history/index.html
@proeung may we please move the Tag manager script below the Onetrust script? The Onetrust script needs to load first so if visitors choose to not accept cookies, some of the tag manager scripts won't load.
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
@proeung may we please move the Tag Manager script below the Onetrust script? The Onetrust script needs to load first so if visitors choose to not accept cookies, some of the tag manager scripts won't load.
@keith-kaplan That's good to know. I was just following the script load order that we had on the AEM dev environment (view-source:https://dev.merative.com/resources/history).
Changes are up, can you take a look again? https://github.com/hlxsites/merative2/pull/251/commits/5bfebccb860e15869f2346e3490409239af85c00
Looks great. Thank you.
Looks good @proeung
Page | Scores | Audits | |
---|---|---|---|
/resources/history/index.html | ![]() |
Issue
Fixes https://jira.wh-sdlc.watson-health.ibm.com/browse/MERATIVE-726
Description
Changed
/resources/history/
Note
index.html
as the home of/resources/history/
Design Specs
Test URLs
main
): https://main--merative2--hlxsites.hlx.live/Testing Instruction