search

hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

Fix: create a variation of carousel block, testimonial block #262

Closed Danielcodepad closed 1 year ago

Danielcodepad commented 1 year ago

Issue

Fixes #261

Description

Update carousel style and logic for testimonial carousel, a variant of Carousel block.

Test URLs

Testing Instruction

The carousel behavior and look-and-feel in the draft should align with the Carousel in Merative live site. See the following page:

https://www.merative.com/clinical-development

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
helms-charity commented 1 year ago

Converted to draft PR until this is ready for further review

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
helms-charity commented 1 year ago

@sachinmesh this is ready for Design QA review.

sachinmesh commented 1 year ago

HI @helms-charity , The spacing between speaker icon, name and title with the quote to be 32px in mobile and tablet. Desktop 24px is correct.

CC: @proeung @keith-kaplan

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/Kunwar/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
helms-charity commented 1 year ago

@sachinmesh this is ready for another review.

sachinmesh commented 1 year ago

Yup @helms-charity this is good to go. Now the spacing in tab/ mobile is 32px and desktop is 24px between speaker icon and quote.

CC: @proeung @keith-kaplan