Closed proeung closed 1 year ago
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/blog/marcy-tatsch-curam | |||
/blog | |||
/blog/meratives-first-year |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/test-blog-detail-page |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/test-blog-detail-page |
HI @proeung Everything looks good. Only on tab/mobile, the spacing between published date and time with tags should be 48px, which 32px now.
CC: @keith-kaplan
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/test-blog-detail-page |
@sachinmesh Thanks for conducting design QA on this PR. I've added a commit to address the spacing issue you've noted above.
@helms-charity or @sahmad-merative Can I get a code review?
@sachinmesh If these changes look good from a design QA perspective and no further changes are needed, please feel free to remove the "Needs Design QA" label and add the "Ready to merge" label so that the team knows that this work is good to go since we have approval from code + design.
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/test-blog-detail-page |
Good to go. I can't change the label, as i don't have the access to edit the PR. @proeung
Issue
Fixes https://github.com/hlxsites/merative2/issues/236
Description
Changed
Design Specs
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/drafts/putra/test-blog-detail-pageTesting Instruction