hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(article-detail): add new design changes for publication placement #265

Closed proeung closed 1 year ago

proeung commented 1 year ago

Issue

Fixes https://github.com/hlxsites/merative2/issues/236

Description

Changed

Design Specs

Test URLs

Screen Shot 2023-06-29 at 10 22 32 AM

Testing Instruction

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/blog/marcy-tatsch-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/blog/meratives-first-year PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/putra/test-blog-detail-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/putra/test-blog-detail-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 1 year ago

HI @proeung Everything looks good. Only on tab/mobile, the spacing between published date and time with tags should be 48px, which 32px now.

image

CC: @keith-kaplan

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/putra/test-blog-detail-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@sachinmesh Thanks for conducting design QA on this PR. I've added a commit to address the spacing issue you've noted above.

Screen Shot 2023-06-30 at 9 47 07 AM

@helms-charity or @sahmad-merative Can I get a code review?

proeung commented 1 year ago

@sachinmesh If these changes look good from a design QA perspective and no further changes are needed, please feel free to remove the "Needs Design QA" label and add the "Ready to merge" label so that the team knows that this work is good to go since we have approval from code + design.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/putra/test-blog-detail-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 1 year ago

Good to go. I can't change the label, as i don't have the access to edit the PR. @proeung