hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(lead-gen): background color less specificity for .cta-container #268

Closed helms-charity closed 1 year ago

helms-charity commented 1 year ago

Issue

Fixes #267

Description

Add a human-readable description/detailed summary of what the PR is changing and any details about how and why. If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application.

New

Changed

.cta-container class is less specific with the default neutral-beige color, allowing section metadata color choice to override.

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

- Figma Link -

Test URLs

Testing Instruction

See the 2 CTA sections on my draft page to compare.

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/chelms/2023-zelta-user-conference PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/chelms/2023-zelta-user-conference PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 1 year ago

Hi @helms-charity @proeung Only thing here is spacing between title and CTA should be 32px in all breakpoints. Here is the figma link https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1461-14252&mode=design&t=KkdJW1rrX1842X9a-4

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/chelms/2023-zelta-user-conference PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@sachinmesh Thanks for conducting design QA for this PR. I just pushed up a commit that adjusted the spacing between the title and CTA to 32px. Can you take a look again?

Screen Shot 2023-07-06 at 11 11 12 AM

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/chelms/2023-zelta-user-conference PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI