hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(support-pages): Add a new import script #275

Closed amol-anand closed 9 months ago

amol-anand commented 1 year ago

Issue

Fixes #256 Fixes #280 Fixes #281

Description

Added a new import script to import Support pages to Franklin

New

Changed

Testing Instruction

Before: https://main--merative2--hlxsites.hlx.page/support/micromedex-product-support-details After: https://support-pages-import--merative2--hlxsites.hlx.page/support/micromedex-product-support-details After: https://support-pages-import--merative2--hlxsites.hlx.page/support/spm/flashes/configure-target-issue-jdbc-connection After: https://support-pages-import--merative2--hlxsites.hlx.page/support/spm/support-articles

In Progress

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
keith-kaplan commented 1 year ago

I haven't had that conversation yet. I'd like to this to be in a bit better shape to show them. I know som of the sidebar features are controlled by shortcodes/fragments in AEM. We'll need to look into having that implemented.

proeung commented 1 year ago

@keith-kaplan Yeah, that makes sense. Looks like the breadcrumbs and sidebar (document info) will need to be treated as block fragments so that they're re-usable on other pages.

amol-anand commented 1 year ago

Is there a way to bulk publish these pages once we're ready to switch the routing from AEM to Franklin

Yes. Using the sidekick from sharepoint folder level we can select multiple files and then preview and publish.

Looks like the breadcrumbs and sidebar (document info) will need to be treated as block fragments so that they're re-usable on other pages.

Agreed. Let's create two separate issues for the sidebar and breadcrumb. Once those are built, then we can modify this script to include them if they exist on the page. I would keep this PR open until that is completed.

proeung commented 1 year ago

@amol-anand Here are the two issues related to the support migration work. Also, @keith-kaplan feel free to adjust the description if there are some details that are missing.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 12 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

@amol-anand Any update on the remaining work for the Support pages migration? Also, are you planning on opening a new PR or working within this one?

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
amol-anand commented 11 months ago

@amol-anand Any update on the remaining work for the Support pages migration? Also, are you planning on opening a new PR or working within this one?

I'm going to work in this same PR to resolve the two outstanding issues. Something I am looking to work on this week.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/support/micromedex-product-support-details PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/flashes/configure-target-issue-jdbc-connection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/spm/support-articles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
keith-kaplan commented 11 months ago

@proeung added a few more details for the metadata rows that need to be added.

For all of the SPM Pages

For all of the Integrated Care Pages

proeung commented 9 months ago

Closing this PR in favor of this new one (https://github.com/hlxsites/merative2/pull/346) that resolves all merge conflicts and include missing styles and code clean up.