search

hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(thought-leadership): add URL/query parameter to sidebar filters #279

Closed sahmad-merative closed 1 year ago

sahmad-merative commented 1 year ago

Issue

Fixes #

Description

Added deep linking within each filtering within the Thought Leadership landing filters selected are added to the url query params and when link is directly used, thought leadership page loads withfilters pre-selected New

Changed

Removed

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Before (Changes from feat/thought-leadership): https://feat-thought-leadership--merative2--hlxsites.hlx.page/thought-leadership After (Changes from this PR): https://753-query-param-sidebar--merative2--sahmad-merative.hlx.page/thought-leadership

Testing Instruction

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI
proeung commented 1 year ago

@sahmad-merative https://github.com/hlxsites/merative2/pull/286 has been merged into the feature branch. Please rebase or open a new PR that includes the changes for exposing the query parameter for the filtering items.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/thought-leadership PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sharathmrft commented 1 year ago

@sahmad-merative @proeung

Tested all the filters URL Individually its working fine except Hero banner and the Image needs to be displayed as I mentioned above for 'Health Insights' and 'Market scan'

@Shalini-SB @keith-kaplan

sharathmrft commented 1 year ago

@proeung Looks fine now.