search

hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(content-band-list-block): Content band list block. #288

Closed nimithshetty17 closed 11 months ago

nimithshetty17 commented 11 months ago

Issue

Fixes #MERATIVE-781

Description

This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. Sections > Section Content band list Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems.

New

image

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

https://content-band-list-block--merative2--nimithshetty17.hlx.page/block-library/sections/section-content-band-list

Testing Instruction

To test the content band list and its responsiveness with respect to the design across all devices.

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 11 months ago

@sachinmesh @proeung - Have made all the requested changes. Please have a look and let me know if there are any concerns.

sachinmesh commented 11 months ago

HI @nimithshetty17 Checked this testing URL https://content-band-list-block--merative2--nimithshetty17.hlx.page/block-library/sections/section-content-band-list

These still needs to be done

image image
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 11 months ago

Branch not getting updated with the latest commits.