chore(csp): add Adobe Target Script and Salesloft Script

hlxsites / merative2

Merative.com site on Franklin

https://merative.com

Apache License 2.0

2 stars 9 forks source link

chore(csp): add Adobe Target Script and Salesloft Script #290

Closed proeung closed 1 year ago

proeung commented 1 year ago

Issue

Fixes - https://github.com/hlxsites/merative2/issues/289

Description

Changed

This PR updates both CSPs on Franklin to allow for *.tt.omtrdc.net and *.salesloft.com
See screenshots for the current issues.

Design Specs

Figma Link - N/A

Test URLs

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/
After (Changes from this PR): https://289-chore-update-csp--merative2--proeung.hlx.page

Testing Instruction

No testing instruction is needed.

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

[ ] Re-run PSI Checks

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/

proeung commented 1 year ago

@keith-kaplan Done. Please check the latest commit.

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/

keith-kaplan commented 1 year ago

@proeung this looked like it fixed the issue. I'm going to submit an Adobe Support ticket to just ensure we have all things setup in Target properly. There are a few other errors I'm seeing in the console when editing and want to make sure I'm not missing anything.

proeung commented 1 year ago

@keith-kaplan Sounds good! Also, feel free to capture those errors that you see in the console in a ticket so that we can help debug where the issue is coming from. In the meantime, I'll go ahead and merge this PR down.