hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(pdf-viewer): add design enhancement #293

Closed proeung closed 1 year ago

proeung commented 1 year ago

Issue

Fixes: https://jira.sdlc.merative.com/browse/MERATIVE-798

Description

Changed

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Testing Instruction

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

Screen Shot 2023-07-20 at 5 07 59 PM

Screen Shot 2023-07-20 at 5 07 30 PM

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/documents/case-study/prudential-case-study PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/documents/white-paper/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/documents/case-study/prudential-case-study PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/documents/white-paper/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@keith-kaplan Thanks for the review! Just added a commit to adjust the embed mode to the default frame view based on my review with Annmaire and Sarah.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/documents/case-study/prudential-case-study PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/documents/white-paper/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI